Skip to content

fix(files): Disable tags editing for shared files/folders with view only permission - #47149

Merged
skjnldsv merged 2 commits into
masterfrom
fix/disable-tags-editing
Aug 9, 2024
Merged

fix(files): Disable tags editing for shared files/folders with view only permission#47149
skjnldsv merged 2 commits into
masterfrom
fix/disable-tags-editing

Conversation

@AndyScherzinger

@AndyScherzingerAndyScherzinger commented Aug 9, 2024•
edited by skjnldsv
Loading

Copy link
Copy Markdown
Member

Replicating #46663 to run all actions

How to reproduce

  1. Create file/folder and assign some tags to it
  2. Share it with another user "user" with view only permission
  3. Open it by "user"

Expected result: user not able remove/add tags
Actual result: user able remove/add tags on UI (we have http 403 on the server side, but UI allows this actions)

🔍 Folder details for admin

image

🔍 Folder details for user

image

Checklist

@Koc@AndyScherzinger
fix(files): Disable tags editing for shared files/folders with view o…
81ee1ce
…nly permission
Signed-off-by: Konstantin Myakshin <molodchick@gmail.com>
@AndyScherzingerAndyScherzinger added bug 3. to review Waiting for reviews labels Aug 9, 2024
@AndyScherzingerAndyScherzinger added this to the Nextcloud 30 milestone Aug 9, 2024
@AndyScherzinger

AndyScherzinger commented Aug 9, 2024

Copy link
Copy Markdown
MemberAuthor

/compile /

@AndyScherzinger

AndyScherzinger commented Aug 9, 2024•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Originally reviewed and approved by @susnux and @Pytal

@AndyScherzingerAndyScherzinger mentioned this pull request Aug 9, 2024
Closed
4 tasks
@nextcloud-command
chore(assets): Recompile assets
de769f0
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish feature: files and removed 3. to review Waiting for reviews labels Aug 9, 2024
@skjnldsv
skjnldsv enabled auto-merge August 9, 2024 11:46
@skjnldsv
skjnldsv disabled auto-merge August 9, 2024 11:52
@skjnldsv
skjnldsv merged commit 81b01c2 into masterAug 9, 2024
@skjnldsv
skjnldsv deleted the fix/disable-tags-editing branch August 9, 2024 11:52
@AndyScherzinger

AndyScherzinger commented Aug 9, 2024

Copy link
Copy Markdown
MemberAuthor

@Koc Merged! Thanks for the fix! 🎉

@skjnldsvskjnldsv mentioned this pull request Aug 13, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnuxsusnuxsusnux approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes
@nextcloud-commandnextcloud-commandnextcloud-command approved these changes

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugfeature: files

Projects

None yet

Milestone

Nextcloud 30

Development

Successfully merging this pull request may close these issues.

5 participants

@AndyScherzinger@susnux@skjnldsv@nextcloud-command@Koc