Skip to content

[stable28] Fix/comment deleting with activities installed - #47233

Merged
skjnldsv merged 1 commit into
stable28from
backportof/45848/stable28_
Aug 22, 2024
Merged

[stable28] Fix/comment deleting with activities installed#47233
skjnldsv merged 1 commit into
stable28from
backportof/45848/stable28_

Conversation

@GretaD

Copy link
Copy Markdown
Contributor

backport of #45848

@GretaD

Copy link
Copy Markdown
ContributorAuthor

/compile amend /

@GretaDGretaD self-assigned this Aug 14, 2024
@GretaDGretaD added the bug label Aug 14, 2024
@GretaD
GretaD marked this pull request as ready for review August 14, 2024 11:43
@GretaDGretaD added this to the Nextcloud 28.0.9 milestone Aug 14, 2024
@nextcloud-command
nextcloud-commandforce-pushed the backportof/45848/stable28_ branch from 24087de to 0f7bc7cCompareAugust 14, 2024 12:05
@GretaD

Copy link
Copy Markdown
ContributorAuthor

/compile amend /

@nextcloud-command
nextcloud-commandforce-pushed the backportof/45848/stable28_ branch from 0f7bc7c to 10b81edCompareAugust 19, 2024 16:26
Comment threaddist/comments-comments-tab.js Outdated

Check warning

Code scanning / CodeQL

Prototype-polluting function

Properties are copied from [e](1) to [t](2) without guarding against prototype pollution.
@GretaD

Copy link
Copy Markdown
ContributorAuthor

/compile amend /

@nextcloud-command
nextcloud-commandforce-pushed the backportof/45848/stable28_ branch from 10b81ed to df2dd27CompareAugust 19, 2024 17:35

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflicts

@GretaD
GretaDforce-pushed the backportof/45848/stable28_ branch from df2dd27 to 882ef07CompareAugust 20, 2024 09:54
@skjnldsvskjnldsv mentioned this pull request Aug 20, 2024
12 tasks
@GretaD
GretaDforce-pushed the backportof/45848/stable28_ branch from 882ef07 to 5a1d356CompareAugust 21, 2024 07:16
@skjnldsvskjnldsv changed the title Stable28: fix comment deletion[stable28] fix comment deletionAug 21, 2024
@skjnldsvskjnldsv changed the title [stable28] fix comment deletion[stable28] Fix/comment deleting with activities installedAug 21, 2024
Comment threadapps/comments/src/services/CommentsInstance.js Outdated
Comment threadapps/comments/src/services/CommentsInstance.js Outdated
@GretaD
GretaDforce-pushed the backportof/45848/stable28_ branch from 5a1d356 to 72c439bCompareAugust 21, 2024 09:02
@GretaD

Copy link
Copy Markdown
ContributorAuthor

/compile amend /

@GretaD
GretaDforce-pushed the backportof/45848/stable28_ branch from 72c439b to 1571b44CompareAugust 21, 2024 13:41
@nextcloud-command
nextcloud-commandforce-pushed the backportof/45848/stable28_ branch from 1571b44 to 7b659b0CompareAugust 21, 2024 14:23
Signed-off-by: greta <gretadoci@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@GretaD
GretaDforce-pushed the backportof/45848/stable28_ branch from 7b659b0 to 4b0dc13CompareAugust 22, 2024 08:16
@skjnldsv
skjnldsv merged commit a0fbc5b into stable28Aug 22, 2024
@skjnldsv
skjnldsv deleted the backportof/45848/stable28_ branch August 22, 2024 10:52
@skjnldsvskjnldsv added the 4. to release Ready to be released and/or waiting for tests to finish label Aug 22, 2024
@blizzzblizzz mentioned this pull request Sep 4, 2024
1 task
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@GretaD@ChristophWurst@miaulalala@skjnldsv@github-advanced-security@AndyScherzinger