Uh oh!
There was an error while loading. Please reload this page.
[stable30] fix(webauthn): Increase database column for public key id - #47249
Merged
Conversation
susnux
approved these changes
Aug 15, 2024
skjnldsv
approved these changes
Aug 15, 2024
susnuxforce-pushed
the
backport/47240/stable30
branch
from
August 22, 2024 09:54
17ca457 to
d101e07CompareUh oh!
There was an error while loading. Please reload this page.
susnuxforce-pushed
the
backport/47240/stable30
branch
from
August 22, 2024 11:34
d101e07 to
41c222bCompareUh oh!
There was an error while loading. Please reload this page.
* Resolves#34476 There is no maximum length defined in the standard, most common the length is between 128 and 200 characters, but as we store it not in plain data but base64 encoded the length can grow about 1/3. We had a regression with 'Nitrokey 3' which created IDs with 196 byte length -> 262 bytes encoded base64. So to be save we increase the size to 512 bytes. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
nickvergessenforce-pushed
the
backport/47240/stable30
branch
from
August 22, 2024 12:43
41c222b to
aa383a8Comparenickvergessen
approved these changes
Aug 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #47240