Uh oh!
There was an error while loading. Please reload this page.
fix: Do not throw if appstore is unavailable during upgrade - #47285
Merged
Conversation
juliusknorr
requested review from
a team, Altahrim, ArtificialOwl and yemkareems
and removed request for
a teamAugust 16, 2024 16:23
susnux
approved these changes
Aug 16, 2024
susnux
commented
Aug 16, 2024
Contributor
/backport to stable30 |
juliusknorr
requested review from
a team, Altahrim and sorbaugh
and removed request for
a team and AltahrimAugust 29, 2024 13:45
sorbaugh
approved these changes
Aug 29, 2024
juliusknorrforce-pushed
the
fix/appstore-upgrade-failure
branch
from
August 30, 2024 09:05
9f532b0 to
5c9d32bCompareskjnldsv
enabled auto-merge
September 4, 2024 07:17
skjnldsv
approved these changes
Sep 4, 2024
skjnldsv
disabled auto-merge
September 4, 2024 07:29
Signed-off-by: Julius Härtl <jus@bitgrid.net>
skjnldsvforce-pushed
the
fix/appstore-upgrade-failure
branch
from
September 4, 2024 07:31
1281f44 to
3ca7480Compare Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of throwing an error we just return an empty list as it is also done if there was a previous error a few lines above and instead just log it.
Otherwise this may leave apps disabled that used to be enabled before:
server/lib/private/Updater.php
Lines 386 to 393 in dae7c15
Checklist