Skip to content

fix: adding blurhash to definitions - #47331

Merged
nickvergessen merged 1 commit into
masterfrom
skalidindi53/12351/Add-blurhash-to-richobjectstrings
Aug 21, 2024
Merged

fix: adding blurhash to definitions#47331
nickvergessen merged 1 commit into
masterfrom
skalidindi53/12351/Add-blurhash-to-richobjectstrings

Conversation

@skalidindi53

@skalidindi53skalidindi53 commented Aug 19, 2024

Copy link
Copy Markdown

Summary

  • Added blurhash to RichObjectString definitions

Checklist

@skalidindi53skalidindi53 added the 2. developing Work in progress label Aug 19, 2024
@skalidindi53skalidindi53 self-assigned this Aug 19, 2024
@skalidindi53
skalidindi53force-pushed the skalidindi53/12351/Add-blurhash-to-richobjectstrings branch 3 times, most recently from b714a6f to 2aa64dfCompareAugust 19, 2024 16:52
@skalidindi53
skalidindi53 marked this pull request as draft August 19, 2024 16:53
@provokateurin

Copy link
Copy Markdown
Member

Thanks for the PR, please make sure it is based on the latest master state and then do a composer i and ./build/openapi-checker.sh. That should remove all the unintended OpenAPI changes.

@provokateurin

Copy link
Copy Markdown
Member

Also the changes in lib/composer have to be reverted

@provokateurinprovokateurin added this to the Nextcloud 31 milestone Aug 19, 2024
@provokateurinprovokateurin added the technical debt 🧱 🤔🚀 label Aug 19, 2024
@provokateurin

Copy link
Copy Markdown
Member

Ah I see what is going on, the lockfiles in vendor-bin have been changed and that is causing the OpenAPI changes. So please remove all changes except for lib/public.

Comment threadlib/public/RichObjectStrings/Definitions.php Outdated
@skalidindi53
skalidindi53force-pushed the skalidindi53/12351/Add-blurhash-to-richobjectstrings branch 2 times, most recently from 6f0a804 to 2ec43d1CompareAugust 19, 2024 18:49
Signed-off-by: skalidindi53 <s.teja2004@gmail.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
nickvergessenforce-pushed the skalidindi53/12351/Add-blurhash-to-richobjectstrings branch from 2ec43d1 to 3a67168CompareAugust 20, 2024 06:25

@nickvergessennickvergessen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted all unrelated parts

@nickvergessen

Copy link
Copy Markdown
Member

/backport to stable30

@nickvergessen
nickvergessen marked this pull request as ready for review August 20, 2024 10:11
@nickvergessen
nickvergessen merged commit 7fe62b9 into masterAug 21, 2024
@welcome

welcomeBot commented Aug 21, 2024

Copy link
Copy Markdown

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@nickvergessen
nickvergessen deleted the skalidindi53/12351/Add-blurhash-to-richobjectstrings branch August 21, 2024 09:59
@skjnldsvskjnldsv mentioned this pull request Jan 7, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developingWork in progresstechnical debt🧱 🤔🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@skalidindi53@provokateurin@nickvergessen