Uh oh!
There was an error while loading. Please reload this page.
fix: Display 'Leave share' instead of 'Delete' - #47339
Merged
Merged
Conversation
marcelklehr
requested review from
a team, artonge, nfebe and skjnldsv
and removed request for
a teamAugust 20, 2024 09:43
marcelklehrforce-pushed
the
fix/leave-share-instead-of-delete
branch
from
August 20, 2024 09:43
99e6f23 to
70a642cCompareUh oh!
There was an error while loading. Please reload this page.
skjnldsv
approved these changes
Aug 20, 2024
skjnldsv
requested changes
Aug 20, 2024
skjnldsvforce-pushed
the
fix/leave-share-instead-of-delete
branch
from
August 20, 2024 12:13
70a642c to
10259c3Compareskjnldsv
requested review from
ArtificialOwl, ChristophWurst, Pytal, come-nc, danxuliu, datenangebot, icewind1991, julien-nc, juliusknorr, kesselb, miaulalala, nickvergessen, provokateurin, susnux, szaimen and tcitworld
as code ownersAugust 20, 2024 12:13
marcelklehr
commented
Aug 20, 2024
MemberAuthor
/backport to stable29 |
marcelklehr
commented
Aug 20, 2024
MemberAuthor
/backport to stable28 |
skjnldsv
commented
Aug 20, 2024
Member
I need to fix unit tests |
susnux
approved these changes
Aug 20, 2024
AndyScherzingerforce-pushed
the
fix/leave-share-instead-of-delete
branch
2 times, most recently
from
August 21, 2024 19:05
a358356 to
e77b4b9Compareskjnldsv
commented
Aug 21, 2024
Member
Stop rebasing @AndyScherzinger , tests needs fixing |
AndyScherzinger
commented
Aug 21, 2024
Member
Sure thing @skjnldsv - thought it's about tests elsewhere and a rebase might help 😅 |
skjnldsvforce-pushed
the
fix/leave-share-instead-of-delete
branch
2 times, most recently
from
August 22, 2024 08:03
97d179f to
73946bfCompareUh oh!
There was an error while loading. Please reload this page.
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
marcelklehr
commented
Sep 6, 2024
MemberAuthor
Oof, this turned out to be a deeper rabbit hole than I anticipated. Thank you for digging into this @skjnldsv 💙 |
skjnldsv
commented
Sep 6, 2024
Member
Yeah 🥲🫠🫠🫠 |
skjnldsv
commented
Sep 6, 2024
Member
Still a few tests to adjust 😅 |
…eck methods Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
skjnldsv
commented
Sep 11, 2024
Member
Finally! 😓 |
2 tasks
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
skjnldsv
commented
Sep 11, 2024
Member
/backport to stable29 |
2 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In files in the "Shared With Me" view, shares' context menu display a "Delete" entry when it should say "Leave this share". This PR fixes that.
Checklist