Skip to content

fix(files): Move loading icon before grid toggle - #47370

Merged
susnux merged 2 commits into
masterfrom
fix/loading-icon
Aug 21, 2024
Merged

fix(files): Move loading icon before grid toggle#47370
susnux merged 2 commits into
masterfrom
fix/loading-icon

Conversation

@susnux

@susnuxsusnux commented Aug 21, 2024

Copy link
Copy Markdown
Contributor

Summary

This prevents jumping of that toggle button when the view is loading. Also adjust the design for Nextcloud 30 (prevent jumping of breadcrumbs when loading due to increased height).

Before

Bildschirmaufnahme_20240821_022625.webm

After

Bildschirmaufnahme_20240821_022550.webm

Checklist

@susnuxsusnux added bug design Design, UI, UX, etc. 3. to review Waiting for reviews feature: files labels Aug 21, 2024
@susnuxsusnux added this to the Nextcloud 31 milestone Aug 21, 2024
@susnux
susnux requested a review from a teamAugust 21, 2024 00:30
@susnux
susnux requested a review from skjnldsv as a code ownerAugust 21, 2024 00:30
@susnux
susnux requested review from artonge and nfebe and removed request for a teamAugust 21, 2024 00:30
@susnux

Copy link
Copy Markdown
ContributorAuthor

/backport to stable30

@susnux

Copy link
Copy Markdown
ContributorAuthor

/compile

This prevents jumping of that toggle button when the view is loading.
Also adjust the design for Nextcloud 30 (prevent jumping of breadcrumbs when loading due to increased height).
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
susnux merged commit 974cda6 into masterAug 21, 2024
@susnux
susnux deleted the fix/loading-icon branch August 21, 2024 12:37
@susnuxsusnux mentioned this pull request Aug 31, 2024
28 tasks
@skjnldsvskjnldsv mentioned this pull request Jan 7, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbugdesignDesign, UI, UX, etc.feature: files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: List/grid toggle jumps while loading

3 participants

@susnux@artonge@skjnldsv