Uh oh!
There was an error while loading. Please reload this page.
feat(files): Allow more than 50 favorite views - #47400
Merged
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
susnux
approved these changes
Aug 21, 2024
susnux
left a comment
Contributor
There was a problem hiding this comment.
Nice! Fix, cleanup and semi-feature 😄
skjnldsv
approved these changes
Aug 21, 2024
susnuxforce-pushed
the
feat/load-more-than-50-faves
branch
2 times, most recently
from
August 24, 2024 10:17
4f911c4 to
c887c14Comparesusnux
commented
Aug 24, 2024
Contributor
/backport to stable30 |
susnuxforce-pushed
the
feat/load-more-than-50-faves
branch
from
August 24, 2024 10:37
c887c14 to
36c6fc6ComparePytalforce-pushed
the
feat/load-more-than-50-faves
branch
from
August 26, 2024 18:05
36c6fc6 to
7117356Compare…retrieval Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de> Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Pytalforce-pushed
the
feat/load-more-than-50-faves
branch
from
August 27, 2024 22:39
7117356 to
a1f4396ComparePytal
commented
Aug 27, 2024
MemberAuthor
/compile / |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2 tasks
Merged
susnux
commented
Jun 23, 2025
Contributor
For 29: #53643 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Technically this is a feature but could also be considered a fix. Favorites were being loaded with a hardcoded limit
server/apps/files/lib/Activity/Helper.php
Line 17 in c3ad469
Checklist