Skip to content

test(admin_audit): add test for user management listener - #47414

Merged
blizzz merged 1 commit into
masterfrom
debt/noid/user-changed-event
Oct 2, 2024
Merged

test(admin_audit): add test for user management listener #47414
blizzz merged 1 commit into
masterfrom
debt/noid/user-changed-event

Conversation

@kesselb

@kesselbkesselb commented Aug 22, 2024

Copy link
Copy Markdown
Contributor
  • Resolves: technical debt

Summary

The migration to event listener was done by #47865.

Good bye hooks, hello event listener (at least for one case)

Test cases:

- Enable admin_audit
- Enable user => see log line in audit log
- Change email for user => see log line in audit log

TODO

  • CI
  • Review
  • Merge

Checklist

@kesselbkesselb added 3. to review Waiting for reviews technical debt 🧱 🤔🚀 labels Aug 22, 2024
@kesselbkesselb added this to the Nextcloud 31 milestone Aug 22, 2024
@kesselbkesselb self-assigned this Aug 22, 2024
@come-nc

Copy link
Copy Markdown
Contributor

@kesselb conflicts 😉

@kesselb
kesselbforce-pushed the debt/noid/user-changed-event branch from d30b988 to 83ad425CompareSeptember 16, 2024 08:51
@kesselbkesselb changed the title refactor: use event listener instead of user changed hooktest(admin_audit): add test for user management listener Sep 16, 2024
@kesselb

Copy link
Copy Markdown
ContributorAuthor

@come-nc resolved 🎉

@kesselb
kesselbforce-pushed the debt/noid/user-changed-event branch from 83ad425 to 9791084CompareSeptember 23, 2024 10:52
@kesselb
kesselb requested review from a team, Altahrim, nfebe and provokateurin and removed request for a teamSeptember 23, 2024 10:52
Comment threadapps/admin_audit/tests/Listener/UserManagementEventListenerTest.php Outdated
Comment threadapps/admin_audit/tests/Listener/UserManagementEventListenerTest.php Outdated
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb
kesselbforce-pushed the debt/noid/user-changed-event branch from 9791084 to 5cf67c2CompareSeptember 23, 2024 11:06
@blizzz
blizzz merged commit b3ca5b5 into masterOct 2, 2024
@blizzz
blizzz deleted the debt/noid/user-changed-event branch October 2, 2024 09:25
@skjnldsvskjnldsv mentioned this pull request Jan 7, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewstechnical debt🧱 🤔🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@kesselb@come-nc@provokateurin@blizzz