Skip to content

fix(mailer): Call to custom mail_template_class - #47435

Merged
nickvergessen merged 2 commits into
nextcloud:masterfrom
phreaker0:fix-mail-template-class-call
Aug 26, 2024
Merged

fix(mailer): Call to custom mail_template_class#47435
nickvergessen merged 2 commits into
nextcloud:masterfrom
phreaker0:fix-mail-template-class-call

Conversation

@phreaker0

@phreaker0phreaker0 commented Aug 22, 2024

Copy link
Copy Markdown
Contributor

Summary

In case of a custom mail_template_class the class is called with missing parameters (which were introduced in 29.0.5). This patch works for me.

Checklist

@solracsfsolracsf changed the title fix call to custom mail_template_classfix(mailer): Call to custom mail_template_classAug 22, 2024
@solracsfsolracsf added the 3. to review Waiting for reviews label Aug 22, 2024
@solracsfsolracsf added this to the Nextcloud 31 milestone Aug 22, 2024
@kesselbkesselb added the bug label Aug 22, 2024

@kesselbkesselb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much 👍

@kesselb

Copy link
Copy Markdown
Contributor

/backport to stable29

@kesselb

Copy link
Copy Markdown
Contributor

/backport to stable28

@kesselb

Copy link
Copy Markdown
Contributor

/backport to stable30

@nickvergessen

Copy link
Copy Markdown
Member

Now it breaks real custom templates that do not extend the existing base class, but I guess I missed is_a($class, EMailTemplate::class, true) which means all of them should extend this.

@susnuxsusnux added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 23, 2024
@nickvergessen
nickvergessen merged commit 36f272d into nextcloud:masterAug 26, 2024
@welcome

welcomeBot commented Aug 26, 2024

Copy link
Copy Markdown

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@github-actions

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugfeature: emailsfeature: themingfeedback-requestedregression

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: custom mail template class is broken in 29.0.5 / 28.0.9

6 participants

@phreaker0@kesselb@nickvergessen@joshtrichards@susnux@solracsf