Skip to content

[stable28] fix(FileList): Show correct avatar for federated share owner - #47441

Merged
nfebe merged 2 commits into
stable28from
44287-fix-avatar-fed-share-receiver
Sep 19, 2024
Merged

[stable28] fix(FileList): Show correct avatar for federated share owner#47441
nfebe merged 2 commits into
stable28from
44287-fix-avatar-fed-share-receiver

Conversation

@nfebe

@nfebenfebe commented Aug 22, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Screenshot

Screenshot from 2024-09-18 16-54-57

Resolves : #44287

@nfebenfebe added 2. developing Work in progress federated labels Aug 22, 2024
nfebe
nfebe commented Aug 22, 2024
View reviewed changes
Comment threadapps/files_sharing/src/utils/AccountIcon.ts Outdated
@Pytal

This comment was marked as resolved.

Sign in to view
@nfebe

This comment was marked as resolved.

Sign in to view
@susnux

This comment was marked as resolved.

Sign in to view
@nfebe

This comment was marked as resolved.

Sign in to view
@nfebe
nfebeforce-pushed the 44287-fix-avatar-fed-share-receiver branch 3 times, most recently from a1ba0cf to e531957CompareAugust 26, 2024 10:56
@nfebe
nfebeforce-pushed the 44287-fix-avatar-fed-share-receiver branch from e531957 to b40e85cCompareSeptember 18, 2024 11:17
github-advanced-security[bot]
github-advanced-securityAI found potential problems Sep 18, 2024
View reviewed changes
Comment threadapps/dav/lib/Connector/Sabre/FilesPlugin.php Fixed
Comment threadlib/public/IUser.php Fixed
@skjnldsv

This comment was marked as resolved.

Sign in to view
@backportbotbackportbotBot mentioned this pull request Sep 18, 2024
Closed
2 tasks
@nfebe
nfebeforce-pushed the 44287-fix-avatar-fed-share-receiver branch from b40e85c to 99b6b92CompareSeptember 18, 2024 12:53
github-advanced-security[bot]
github-advanced-securityAI found potential problems Sep 18, 2024
View reviewed changes
Comment threadapps/dav/lib/Connector/Sabre/FilesPlugin.php Fixed
@nfebe
nfebeforce-pushed the 44287-fix-avatar-fed-share-receiver branch 5 times, most recently from b531d7b to 30aaefdCompareSeptember 18, 2024 15:57
@nfebe
nfebe marked this pull request as ready for review September 18, 2024 15:57
@nfebenfebe changed the title WIP : 44287 fix avatar fed share receiver44287 fix avatar fed share receiverSep 18, 2024
@nfebenfebe changed the title 44287 fix avatar fed share receiverfix(FileList): Show correct avatar for federated share ownerSep 18, 2024
@nfebenfebe added 3. to review Waiting for reviews 28-feedback and removed 2. developing Work in progress labels Sep 18, 2024
@nfebenfebe added this to the Nextcloud 28.0.11 milestone Sep 18, 2024
@nfebe

nfebe commented Sep 18, 2024

Copy link
Copy Markdown
ContributorAuthor

/backport to stable29

github-advanced-security[bot]
github-advanced-securityAI found potential problems Sep 18, 2024
View reviewed changes
Comment threadapps/files_sharing/src/actions/sharingStatusAction.ts Fixed
come-nc
come-nc reviewed Sep 18, 2024
View reviewed changes
Comment threadlib/private/User/LazyUser.php Outdated
@skjnldsvskjnldsv changed the title fix(FileList): Show correct avatar for federated share owner[stable28 fix(FileList): Show correct avatar for federated share ownerSep 19, 2024
skjnldsv
skjnldsv reviewed Sep 19, 2024
View reviewed changes
Comment threadlib/private/User/User.php Outdated
icewind1991
icewind1991 reviewed Sep 19, 2024
View reviewed changes
Comment threadapps/dav/lib/Connector/Sabre/FilesPlugin.php Outdated
@nfebe
nfebeforce-pushed the 44287-fix-avatar-fed-share-receiver branch 2 times, most recently from 079bd1e to 6eda58fCompareSeptember 19, 2024 10:39
@nfebe

nfebe commented Sep 19, 2024

Copy link
Copy Markdown
ContributorAuthor

/compile

@nfebenfebe changed the title [stable28 fix(FileList): Show correct avatar for federated share owner[stable28] fix(FileList): Show correct avatar for federated share ownerSep 19, 2024
@nfebe
nfebe enabled auto-merge September 19, 2024 13:55
nfebeand others added 2 commits September 19, 2024 16:18
@nfebe
fix(Federation): Show some icon for federated users on shares
2b40fb4
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
@nextcloud-command@nfebe
chore(assets): Recompile assets
a31607f
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nfebe
nfebeforce-pushed the 44287-fix-avatar-fed-share-receiver branch from 52350a9 to a31607fCompareSeptember 19, 2024 15:18
@nfebe
nfebe merged commit 6d62ca8 into stable28Sep 19, 2024
@nfebe
nfebe deleted the 44287-fix-avatar-fed-share-receiver branch September 19, 2024 20:47
@backportbotbackportbotBot mentioned this pull request Sep 19, 2024
Merged
2 tasks
@nfebenfebe mentioned this pull request Sep 20, 2024
Closed
8 tasks
@AltahrimAltahrim mentioned this pull request Oct 1, 2024
Merged
2 tasks
@nextcloudnextcloud deleted a comment from github-actionsBotNov 7, 2024
@skjnldsvskjnldsv mentioned this pull request Nov 8, 2024
Closed
@susnuxsusnux moved this from 🏗️ In progress to ☑️ Done in 📁 Files teamMar 14, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skjnldsvskjnldsvskjnldsv approved these changes
@come-nccome-nccome-nc approved these changes
@ChristophWurstChristophWurstAwaiting requested review from ChristophWurst
@artongeartongeAwaiting requested review from artonge
@susnuxsusnuxAwaiting requested review from susnux
@icewind1991icewind1991Awaiting requested review from icewind1991

Assignees

No one assigned

Labels

3. to reviewWaiting for reviews28-feedbackfeedback-requested

Projects

📁 Files team
Status: ☑️ Done

Milestone

Nextcloud 28.0.11

Development

Successfully merging this pull request may close these issues.

8 participants

@nfebe@Pytal@susnux@skjnldsv@icewind1991@github-advanced-security@come-nc@nextcloud-command