fix(files): fix list gap at bottom

[elzody]

• Resolves: File list footer is to far away from the list #46860

Summary

Due to a dynamic CSS property in the VirtualList.vue component, there was extra space after the final file in the list whenever the rich workspace is active. This PR removes the naughty part of the height calculation as specified in the issue

Screenshots

Before

After

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[elzody]

/backport to stable30

[elzody]

/backport to stable29

[elzody]

/backport to stable28

[skjnldsv]

I guess the calculation of the height changed at some point and we forgot to remove the beforeHeight. 🤔

@elzody have you tested with a few headers ? Like recommendations and text with a readme ?

EDIT: just did, it's perfect! 👍

[skjnldsv]

/compile amend-rebase /

[susnux]

I guess the calculation of the height changed at some point and we forgot to remove the beforeHeight. 🤔

Last time I touched that logic and copy-pasted but shame on me I did not tested with recommended-files or text installed 🙈

[susnux]

@skjnldsv

EDIT: just did, it's perfect! 👍

Did you also test with a fileid in the URL? So that the scrolling still works? Because the scroll position still takes beforeHeight into account.

[elzody]

@susnux I just gave it a whirl, it seems like it still auto-scrolls so the selected file is still visible.