Skip to content

fix(logger): ignore session logging during setup - #47521

Merged
ArtificialOwl merged 1 commit into
masterfrom
fix/noid/loosing-systemconfig-on-setup
Aug 27, 2024
Merged

fix(logger): ignore session logging during setup#47521
ArtificialOwl merged 1 commit into
masterfrom
fix/noid/loosing-systemconfig-on-setup

Conversation

@ArtificialOwl

@ArtificialOwlArtificialOwl commented Aug 27, 2024•
edited
Loading

Copy link
Copy Markdown
Member

This fix a regression from #47105 that lock installation process on 29.0.5 (but no 30 😕 ) when using the web interface

@ArtificialOwlArtificialOwl mentioned this pull request Aug 27, 2024
Merged
@nickvergessen

nickvergessen commented Aug 27, 2024

Copy link
Copy Markdown
Member

Or we wrap the code with an isInstalled() check?

@ArtificialOwl

ArtificialOwl commented Aug 27, 2024•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

if we can ignore slow session logging during installation process, I could check this in base.php and send a null logger to the Session

nickvergessen
nickvergessen approved these changes Aug 27, 2024
View reviewed changes

@nickvergessennickvergessen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think both makes sense.

@ArtificialOwl
ArtificialOwlforce-pushed the fix/noid/loosing-systemconfig-on-setup branch from d0f57b5 to 509e3f1CompareAugust 27, 2024 12:55
@ArtificialOwl

ArtificialOwl commented Aug 27, 2024

Copy link
Copy Markdown
MemberAuthor

@nickvergessen please check this new way of fixing the issue.

nickvergessen
nickvergessen reviewed Aug 27, 2024
View reviewed changes
Comment threadlib/private/Session/Internal.php Outdated
@ArtificialOwl
fix(setup): ignore long session login during installation
9100b87
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
@ArtificialOwl
ArtificialOwlforce-pushed the fix/noid/loosing-systemconfig-on-setup branch from 509e3f1 to 9100b87CompareAugust 27, 2024 13:30
@ArtificialOwl

ArtificialOwl commented Aug 27, 2024

Copy link
Copy Markdown
MemberAuthor

Thanks. Fixed, squashed and rebased

@ArtificialOwl

ArtificialOwl commented Aug 27, 2024

Copy link
Copy Markdown
MemberAuthor

/backport to stable30

@ArtificialOwl

ArtificialOwl commented Aug 27, 2024

Copy link
Copy Markdown
MemberAuthor

/backport to stable29

@ArtificialOwl

ArtificialOwl commented Aug 27, 2024

Copy link
Copy Markdown
MemberAuthor

(no idea if an urgent new release of 29 is needed)

@ArtificialOwlArtificialOwl changed the title fix(logger): ignore appcontainer for corefix(logger): ignore session logging during setupAug 27, 2024
@solracsfsolracsf added this to the Nextcloud 31 milestone Aug 27, 2024
@ArtificialOwl
ArtificialOwl merged commit e68f77e into masterAug 27, 2024
@ArtificialOwl
ArtificialOwl deleted the fix/noid/loosing-systemconfig-on-setup branch August 27, 2024 19:10
This was referenced Aug 27, 2024
Merged
Merged
@joshtrichards

joshtrichards commented Aug 27, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Confirmed that this fixes nextcloud/docker#2283

@joshtrichards

joshtrichards commented Aug 27, 2024•
edited
Loading

Copy link
Copy Markdown
Member

(no idea if an urgent new release of 29 is needed)

This breaks web based installations. While occ maintenance:install is a workaround, this is a serious bug. There are reports on the community forum as well. I think we need to do a new release.

This was referenced Aug 27, 2024
Closed
Closed
Closed
@skjnldsvskjnldsv mentioned this pull request Jan 7, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessennickvergessennickvergessen approved these changes
@AndyScherzingerAndyScherzingerAndyScherzinger approved these changes
@artongeartongeartonge approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Nextcloud 31

Development

Successfully merging this pull request may close these issues.

6 participants

@ArtificialOwl@nickvergessen@joshtrichards@AndyScherzinger@artonge@solracsf