Skip to content

fix(files_external): Handling in SFTP UI for custom ports - #47527

Merged
joshtrichards merged 1 commit into
masterfrom
fix-sftp-custom-port-ui
Sep 12, 2024
Merged

fix(files_external): Handling in SFTP UI for custom ports#47527
joshtrichards merged 1 commit into
masterfrom
fix-sftp-custom-port-ui

Conversation

@joshtrichards

@joshtrichardsjoshtrichards commented Aug 27, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Summary

Same as #47526 but for SFTP.

TODO

Checklist

@joshtrichards
fix: custom port handling in UI for SFTP
2e73932
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
@joshtrichards

joshtrichards commented Aug 27, 2024

Copy link
Copy Markdown
MemberAuthor

/backport to stable30

@joshtrichards

joshtrichards commented Aug 27, 2024

Copy link
Copy Markdown
MemberAuthor

/backport to stable29

joshtrichards added a commit to nextcloud/documentation that referenced this pull request Aug 27, 2024
@joshtrichards
docs: Update SFTP External Storage custom port instructions
ad95f07
For nextcloud/server#47527
Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichardsjoshtrichards mentioned this pull request Aug 27, 2024
Merged
@solracsfsolracsf added this to the Nextcloud 31 milestone Aug 27, 2024
@joshtrichardsjoshtrichards changed the title fix: custom port handling in UI for SFTPfix(files_external): Handling in SFTP UI for custom port handlingSep 7, 2024
@joshtrichardsjoshtrichards changed the title fix(files_external): Handling in SFTP UI for custom port handlingfix(files_external): Handling in SFTP UI for custom portSep 7, 2024
@joshtrichardsjoshtrichards changed the title fix(files_external): Handling in SFTP UI for custom portfix(files_external): Handling in SFTP UI for custom portsSep 7, 2024
@artonge

artonge commented Sep 9, 2024

Copy link
Copy Markdown
Collaborator

Is this the only wiring needed for it to work? 😲

@joshtrichards

joshtrichards commented Sep 12, 2024

Copy link
Copy Markdown
MemberAuthor

Is this the only wiring needed for it to work? 😲

Yes, seems so. Ends up in the correct place in the config when used.

@joshtrichards
joshtrichards merged commit 56c744d into masterSep 12, 2024
@joshtrichards
joshtrichards deleted the fix-sftp-custom-port-ui branch September 12, 2024 13:34
This was referenced Sep 12, 2024
Merged
Merged
backportbotBot pushed a commit to nextcloud/documentation that referenced this pull request Sep 14, 2024
@joshtrichards@backportbot
docs: Update SFTP External Storage custom port instructions
834f9e0
For nextcloud/server#47527
Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichardsjoshtrichards mentioned this pull request Nov 15, 2024
Open
8 tasks
@skjnldsvskjnldsv mentioned this pull request Jan 7, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnuxsusnuxsusnux approved these changes
@artongeartongeartonge approved these changes
@AltahrimAltahrimAwaiting requested review from Altahrim
@kesselbkesselbAwaiting requested review from kesselb
@icewind1991icewind1991Awaiting requested review from icewind1991
@danxuliudanxuliuAwaiting requested review from danxuliu

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsbugfeature: external storage

Projects

None yet

Milestone

Nextcloud 31

Development

Successfully merging this pull request may close these issues.

Setting custom port from GUI broken for FTP and SFTP External Storage with "other port" usage NEED TO PUT THAT IN DOCUMENT

4 participants

@joshtrichards@artonge@susnux@solracsf