Do not list system users in contacts menu if sharing autocompletion i…

[ChristophWurst]

…s disabled

Fixes#4656

[mention-bot]

@ChristophWurst, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nickvergessen, @schiessle and @LukasReschke to be potential reviewers.

[codecov]

Codecov Report

Merging #4757 into master will decrease coverage by <.01%.
The diff coverage is 60%.

@@ Coverage Diff @@## master #4757 +/- ##
============================================
- Coverage 54.22% 54.21% -0.01% 
Complexity 22135 22135 ============================================
Files 1363 1363 Lines 84795 84798 +3 Branches 1322 1322 ============================================
- Hits 45982 45976 -6 - Misses 38813 38822 +9

Impacted Files	Coverage Δ	Complexity Δ
apps/dav/appinfo/app.php	26.31% <60%> (+1.31%)	0 <0> (ø)	⬇️
apps/comments/lib/EventHandler.php	79.16% <0%> (-8.34%)	7% <0%> (ø)
lib/private/Security/CertificateManager.php	92.78% <0%> (-1.04%)	38% <0%> (ø)
core/js/js.js	61.21% <0%> (-0.57%)	0% <0%> (ø)
lib/private/Server.php	93.51% <0%> (+0.14%)	120% <0%> (ø)	⬇️

[joergmschulz]

Then we can't have autocompletion while sharing AND have the possibility to hide users from other groups?

[ttbek]

This is not a fix, the solution that people were asking for was clear. To show in contacts the same IDs that can be shared to for local users. That is, if sharing is only within groups, then contacts within groups should still show up, but those outside should not. I'm not sure if others want to control these independently, but it should get the same level of granularity that the sharing gets. It doen't make sense to turn off autocomplete for sharing in order to stop users outside of shareable local groups from showing in contacts, the sharing autocomplete already works correctly and doesn't show them.

[ChristophWurst]

Please file a new issue instead of commenting to old closed PRs. Thanks.