fix(theming): Add migration to restore primary color after separating primary and background

[susnux]

• Resolves: [Bug]: custom primary color lost after upgrade from 29 to 30 #46980

Summary

Not sure about the user color part, but at least it works 😅
Meaning not sure if that query would not take long on large instances.

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[AndyScherzinger]

/backport to stable30

[skjnldsv]

use IAppConfig please :)

[susnux]

use IAppConfig please :)

If it is fixed now, then I love to. It had a really bad bug that you cannot mix IConfig->setAppValue and e.g. IAppConfig->setValueBool.
Meaning you have to migrate every access to that value to the types access, in every place. Otherwise after using the typed access you can no longer access it with the IConfig variant.

One recent place were we needed to fix this: #46991

[come-nc]

The config key to check if repair step ran already is too ugly, please use a migration instead which by design run only once.

[susnux]

@come-nc I refactored this again, but we need to put parts of the migration into a background job. As we need to iterate a list of users which could take long if many users had custom backgrounds.

I reused the logic from the dashboard -> theming repair step / background job.

So it is now working correctly for me:

Screen recording

Setup

Bildschirmaufnahme_20240902_165334.webm

After Upgrade to Nextcloud 30 / 31

Please note the wrong colors in the beginning, I triggered the migration then and reload the page:

1. In the beginning the previous primary color is set as background color causes wrong color of icon in the top bar
2. No primary color
3. The admin theming colors are all wrongly reset to default

This is all fixed after the migration + background job ran:

Bildschirmaufnahme_20240902_170942.webm

[come-nc]

Psalm is quite angry

Migrated to IAppConfig

Implemented as migration

[ArtificialOwl]

code looks good