Skip to content

fix(test): Fix provisioning enabled apps - #47596

Merged
nickvergessen merged 1 commit into
masterfrom
fix/test/provisioning-enabled-apps
Aug 29, 2024
Merged

fix(test): Fix provisioning enabled apps#47596
nickvergessen merged 1 commit into
masterfrom
fix/test/provisioning-enabled-apps

Conversation

@provokateurin

@provokateurinprovokateurin commented Aug 29, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Summary

#47532 added the app, but didn't adjust the tests. They didn't even run, because the files were not changed.
Example failure: https://github.com/nextcloud/server/actions/runs/10610490820/job/29408077638

Checklist

@provokateurinprovokateurin added bug 3. to review Waiting for reviews labels Aug 29, 2024
@provokateurinprovokateurin added this to the Nextcloud 31 milestone Aug 29, 2024
@provokateurin
provokateurin requested a review from a teamAugust 29, 2024 07:32
@provokateurin

provokateurin commented Aug 29, 2024

Copy link
Copy Markdown
MemberAuthor

/backport! to stable30

@provokateurinprovokateurin mentioned this pull request Aug 29, 2024
Merged
@backportbotbackportbotBot mentioned this pull request Aug 29, 2024
Merged
nickvergessen
nickvergessen reviewed Aug 29, 2024
View reviewed changes
Comment threadbuild/integration/features/provisioning-v1.feature Outdated
@nextcloudnextcloud deleted a comment from provokateurinAug 29, 2024
@provokateurin
provokateurinforce-pushed the fix/test/provisioning-enabled-apps branch from cc6ac78 to 1b10337CompareAugust 29, 2024 07:40
@provokateurin
fix(test): Fix provisioning enabled apps
54e6103
Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin
provokateurinforce-pushed the fix/test/provisioning-enabled-apps branch from 1b10337 to 54e6103CompareAugust 29, 2024 07:43
@provokateurinprovokateurin added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 29, 2024
@nickvergessen
nickvergessen merged commit 6cfa388 into masterAug 29, 2024
@nickvergessen
nickvergessen deleted the fix/test/provisioning-enabled-apps branch August 29, 2024 09:16
@skjnldsvskjnldsv mentioned this pull request Jan 7, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessennickvergessennickvergessen approved these changes
@juliusknorrjuliusknorrjuliusknorr approved these changes
@szaimenszaimenszaimen approved these changes
@come-nccome-nccome-nc approved these changes

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishbug

Projects

None yet

Milestone

Nextcloud 31

Development

Successfully merging this pull request may close these issues.

5 participants

@provokateurin@nickvergessen@juliusknorr@szaimen@come-nc