Skip to content

[master] Port Same-Site Cookies to master - #476

Merged
LukasReschke merged 1 commit into
masterfrom
port-same-site-cookies
Jul 20, 2016
Merged

[master] Port Same-Site Cookies to master#476
LukasReschke merged 1 commit into
masterfrom
port-same-site-cookies

Conversation

@LukasReschke

Copy link
Copy Markdown
Member

Fixes#50

@LukasReschkeLukasReschke added the 3. to review Waiting for reviews label Jul 20, 2016
@LukasReschkeLukasReschke added this to the Nextcloud Next milestone Jul 20, 2016
@mention-bot

Copy link
Copy Markdown

@LukasReschke, thanks for your PR! By analyzing the annotation information on this pull request, we identified @DeepDiver1975, @BernhardPosselt and @rullzer to be potential reviewers

@MorrisJobke

Copy link
Copy Markdown
Member

💥

PHP Fatal error: Class 'OC\Appframework\Middleware\Security\Exceptions\StrictCookieMissingException' not found in /drone/src/github.com/nextcloud/server/lib/private/AppFramework/Middleware/Security/SecurityMiddleware.php on line 141
[info] build failed (exit code 255)

@LukasReschke

Copy link
Copy Markdown
MemberAuthor

PHP Fatal error: Class 'OC\Appframework\Middleware\Security\Exceptions\StrictCookieMissingException' not found in /drone/src/github.com/nextcloud/server/lib/private/AppFramework/Middleware/Security/SecurityMiddleware.php on line 141
[info] build failed (exit code 255)

How much I love case-sensitive and case-insensitive OS…

@LukasReschke
LukasReschkeforce-pushed the port-same-site-cookies branch from 779d742 to a299fa3CompareJuly 20, 2016 16:38
@LukasReschke

Copy link
Copy Markdown
MemberAuthor

Casing changed. Let's see if Drone is happy now… Tests are passing locally… (well they also passed before but 🙈 yay … computers 😉 )

@rullzer

Copy link
Copy Markdown
Member

👍

@LukasReschke

Copy link
Copy Markdown
MemberAuthor

Since it's a simple port to master: Merge.

@LukasReschke
LukasReschke merged commit 020a2a6 into masterJul 20, 2016
@LukasReschke
LukasReschke deleted the port-same-site-cookies branch July 20, 2016 19:35
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@LukasReschke@mention-bot@MorrisJobke@rullzer