[LinkReferenceProvider] Better size check by julien-nc · Pull Request #47627 · nextcloud/server

julien-nc · 2024-08-30T09:00:41Z

In addition to the HEAD request, check the actual size of the GET request when retrieving a page.
Get the GET request response as a stream, try to read 5 MiB from it and fail if there are more bytes in the stream.

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>

julien-nc · 2024-08-30T09:01:42Z

/backport to stable30

julien-nc · 2024-08-30T09:01:54Z

/backport to stable29

julien-nc · 2024-08-30T09:02:01Z

/backport to stable28

julien-nc · 2024-08-30T09:02:26Z

/backport to stable27

backportbot · 2024-09-02T10:34:01Z

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b backport/47627/stable27
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts, resolve them
git cherry-pick 22bb42be
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/47627/stable27

Error: Failed to clone repository: Failed to checkout branches: Updating 1cc7851..873c42b
From https://github.com/nextcloud/server

[deleted] (none) -> origin/7935-download-files-via-post
[deleted] (none) -> origin/JonathanTreffler-stop-spamming-deprecations
[deleted] (none) -> origin/add-clear-add-to-user-status-public-api
[deleted] (none) -> origin/add-integration-tests-for-getting-folder-sizes
[deleted] (none) -> origin/add-vtimezone-data-when-creating-personal-calendar
[deleted] (none) -> origin/admin_audit/enh/move-to-event-listeners
[deleted] (none) -> origin/artonge/feat/download_providers
[deleted] (none) -> origin/bug/files-scroll
[deleted] (none) -> origin/bugfix/38171/revert-status-when-overwritten
[deleted] (none) -> origin/bugfix/avoid-extra-stream-copy
[deleted] (none) -> origin/bugfix/noid/unavailable-shares
[deleted] (none) -> origin/cache-mimtype-mapping
[deleted] (none) -> origin/chore/catch-missing-non-optional-controller-parameter
[deleted] (none) -> origin/chore/security/log-password-confirmation-user-backend
[deleted] (none) -> origin/dependabot/npm_and_yarn/core-js-3.38.1
[deleted] (none) -> origin/direct-access-shared-calendar
[deleted] (none) -> origin/email-template-html-fragment
[deleted] (none) -> origin/enh/a11y-util
[deleted] (none) -> origin/enh/noid/iconfig
[deleted] (none) -> origin/enh/noid/use-taskprocessing-in-old-managers
[deleted] (none) -> origin/enhancement/caldav-resources-sync-command
[deleted] (none) -> origin/enhancement/typed-db-entity
[deleted] (none) -> origin/external-list-for
[deleted] (none) -> origin/extract-caldav-sharing-plugin
[deleted] (none) -> origin/feat-add-iavaialble-in-maintenance-mode
[deleted] (none) -> origin/feat/mail-admin-vue
[deleted] (none) -> origin/file-cache-insertion-atomic
[deleted] (none) -> origin/fix/44160/ctrl-f-trigger-global-search
[deleted] (none) -> origin/fix/files-non-visual-loading-info
[deleted] (none) -> origin/fix/header-styles
[deleted] (none) -> origin/fix/noid/identity-proof-key-checksum
[deleted] (none) -> origin/fix/user-settings-admin
[deleted] (none) -> origin/home-storage-lazy-datadir
[deleted] (none) -> origin/introduce/orm
[deleted] (none) -> origin/locate-key-fix
[deleted] (none) -> origin/mountcache-lazy-user
[deleted] (none) -> origin/multi-object-store
[deleted] (none) -> origin/remove_depreated_files
[deleted] (none) -> origin/setupmanager-lazy-user
[deleted] (none) -> origin/share-null-source
[deleted] (none) -> origin/storage-cache-init-in-transaction
[deleted] (none) -> origin/trashbin-skip-logging
[deleted] (none) -> origin/upload-chunk-locking
[deleted] (none) -> origin/use_HSTS
[deleted] (none) -> origin/user-files-debug-info
[deleted] (none) -> origin/work/sharing_trash
error: Your local changes to the following files would be overwritten by merge:
dist/4254-4254.js.map.license
dist/4696-4696.js.map.license
dist/5643-5643.js.map.license
Please commit your changes or stash them before you merge.
Aborting

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

backportbot · 2024-09-02T10:34:37Z

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b backport/47627/stable28
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts, resolve them
git cherry-pick 22bb42be
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/47627/stable28

Error: Failed to clone repository: Failed to checkout branches: Updating 1cc7851..873c42b
From https://github.com/nextcloud/server

[deleted] (none) -> origin/7935-download-files-via-post
[deleted] (none) -> origin/JonathanTreffler-stop-spamming-deprecations
[deleted] (none) -> origin/add-clear-add-to-user-status-public-api
[deleted] (none) -> origin/add-integration-tests-for-getting-folder-sizes
[deleted] (none) -> origin/add-vtimezone-data-when-creating-personal-calendar
[deleted] (none) -> origin/admin_audit/enh/move-to-event-listeners
[deleted] (none) -> origin/artonge/feat/download_providers
[deleted] (none) -> origin/bug/files-scroll
[deleted] (none) -> origin/bugfix/38171/revert-status-when-overwritten
[deleted] (none) -> origin/bugfix/avoid-extra-stream-copy
[deleted] (none) -> origin/bugfix/noid/unavailable-shares
[deleted] (none) -> origin/cache-mimtype-mapping
[deleted] (none) -> origin/chore/catch-missing-non-optional-controller-parameter
[deleted] (none) -> origin/chore/security/log-password-confirmation-user-backend
[deleted] (none) -> origin/dependabot/npm_and_yarn/core-js-3.38.1
[deleted] (none) -> origin/direct-access-shared-calendar
[deleted] (none) -> origin/email-template-html-fragment
[deleted] (none) -> origin/enh/a11y-util
[deleted] (none) -> origin/enh/noid/iconfig
[deleted] (none) -> origin/enh/noid/use-taskprocessing-in-old-managers
[deleted] (none) -> origin/enhancement/caldav-resources-sync-command
[deleted] (none) -> origin/enhancement/typed-db-entity
[deleted] (none) -> origin/external-list-for
[deleted] (none) -> origin/extract-caldav-sharing-plugin
[deleted] (none) -> origin/feat-add-iavaialble-in-maintenance-mode
[deleted] (none) -> origin/feat/mail-admin-vue
[deleted] (none) -> origin/file-cache-insertion-atomic
[deleted] (none) -> origin/fix/44160/ctrl-f-trigger-global-search
[deleted] (none) -> origin/fix/files-non-visual-loading-info
[deleted] (none) -> origin/fix/header-styles
[deleted] (none) -> origin/fix/noid/identity-proof-key-checksum
[deleted] (none) -> origin/fix/user-settings-admin
[deleted] (none) -> origin/home-storage-lazy-datadir
[deleted] (none) -> origin/introduce/orm
[deleted] (none) -> origin/locate-key-fix
[deleted] (none) -> origin/mountcache-lazy-user
[deleted] (none) -> origin/multi-object-store
[deleted] (none) -> origin/remove_depreated_files
[deleted] (none) -> origin/setupmanager-lazy-user
[deleted] (none) -> origin/share-null-source
[deleted] (none) -> origin/storage-cache-init-in-transaction
[deleted] (none) -> origin/trashbin-skip-logging
[deleted] (none) -> origin/upload-chunk-locking
[deleted] (none) -> origin/use_HSTS
[deleted] (none) -> origin/user-files-debug-info
[deleted] (none) -> origin/work/sharing_trash
error: Your local changes to the following files would be overwritten by merge:
dist/4254-4254.js.map.license
dist/4696-4696.js.map.license
dist/5643-5643.js.map.license
Please commit your changes or stash them before you merge.
Aborting

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

backportbot · 2024-09-02T10:35:14Z

The backport to stable29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/47627/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts, resolve them
git cherry-pick 22bb42be
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/47627/stable29

Error: Failed to clone repository: Failed to checkout branches: Updating 1cc7851..873c42b
From https://github.com/nextcloud/server

[deleted] (none) -> origin/7935-download-files-via-post
[deleted] (none) -> origin/JonathanTreffler-stop-spamming-deprecations
[deleted] (none) -> origin/add-clear-add-to-user-status-public-api
[deleted] (none) -> origin/add-integration-tests-for-getting-folder-sizes
[deleted] (none) -> origin/add-vtimezone-data-when-creating-personal-calendar
[deleted] (none) -> origin/admin_audit/enh/move-to-event-listeners
[deleted] (none) -> origin/artonge/feat/download_providers
[deleted] (none) -> origin/bug/files-scroll
[deleted] (none) -> origin/bugfix/38171/revert-status-when-overwritten
[deleted] (none) -> origin/bugfix/avoid-extra-stream-copy
[deleted] (none) -> origin/bugfix/noid/unavailable-shares
[deleted] (none) -> origin/cache-mimtype-mapping
[deleted] (none) -> origin/chore/catch-missing-non-optional-controller-parameter
[deleted] (none) -> origin/chore/security/log-password-confirmation-user-backend
[deleted] (none) -> origin/dependabot/npm_and_yarn/core-js-3.38.1
[deleted] (none) -> origin/direct-access-shared-calendar
[deleted] (none) -> origin/email-template-html-fragment
[deleted] (none) -> origin/enh/a11y-util
[deleted] (none) -> origin/enh/noid/iconfig
[deleted] (none) -> origin/enh/noid/use-taskprocessing-in-old-managers
[deleted] (none) -> origin/enhancement/caldav-resources-sync-command
[deleted] (none) -> origin/enhancement/typed-db-entity
[deleted] (none) -> origin/external-list-for
[deleted] (none) -> origin/extract-caldav-sharing-plugin
[deleted] (none) -> origin/feat-add-iavaialble-in-maintenance-mode
[deleted] (none) -> origin/feat/mail-admin-vue
[deleted] (none) -> origin/file-cache-insertion-atomic
[deleted] (none) -> origin/fix/44160/ctrl-f-trigger-global-search
[deleted] (none) -> origin/fix/files-non-visual-loading-info
[deleted] (none) -> origin/fix/header-styles
[deleted] (none) -> origin/fix/noid/identity-proof-key-checksum
[deleted] (none) -> origin/fix/user-settings-admin
[deleted] (none) -> origin/home-storage-lazy-datadir
[deleted] (none) -> origin/introduce/orm
[deleted] (none) -> origin/locate-key-fix
[deleted] (none) -> origin/mountcache-lazy-user
[deleted] (none) -> origin/multi-object-store
[deleted] (none) -> origin/remove_depreated_files
[deleted] (none) -> origin/setupmanager-lazy-user
[deleted] (none) -> origin/share-null-source
[deleted] (none) -> origin/storage-cache-init-in-transaction
[deleted] (none) -> origin/trashbin-skip-logging
[deleted] (none) -> origin/upload-chunk-locking
[deleted] (none) -> origin/use_HSTS
[deleted] (none) -> origin/user-files-debug-info
[deleted] (none) -> origin/work/sharing_trash
error: Your local changes to the following files would be overwritten by merge:
dist/4254-4254.js.map.license
dist/4696-4696.js.map.license
dist/5643-5643.js.map.license
Please commit your changes or stash them before you merge.
Aborting

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

backportbot · 2024-09-02T10:35:53Z

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30
# Create the new backport branch
git checkout -b backport/47627/stable30
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts, resolve them
git cherry-pick 22bb42be
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/47627/stable30

Error: Failed to clone repository: Failed to checkout branches: Updating 1cc7851..873c42b
From https://github.com/nextcloud/server

[deleted] (none) -> origin/7935-download-files-via-post
[deleted] (none) -> origin/JonathanTreffler-stop-spamming-deprecations
[deleted] (none) -> origin/add-clear-add-to-user-status-public-api
[deleted] (none) -> origin/add-integration-tests-for-getting-folder-sizes
[deleted] (none) -> origin/add-vtimezone-data-when-creating-personal-calendar
[deleted] (none) -> origin/admin_audit/enh/move-to-event-listeners
[deleted] (none) -> origin/artonge/feat/download_providers
[deleted] (none) -> origin/bug/files-scroll
[deleted] (none) -> origin/bugfix/38171/revert-status-when-overwritten
[deleted] (none) -> origin/bugfix/avoid-extra-stream-copy
[deleted] (none) -> origin/bugfix/noid/unavailable-shares
[deleted] (none) -> origin/cache-mimtype-mapping
[deleted] (none) -> origin/chore/catch-missing-non-optional-controller-parameter
[deleted] (none) -> origin/chore/security/log-password-confirmation-user-backend
[deleted] (none) -> origin/dependabot/npm_and_yarn/core-js-3.38.1
[deleted] (none) -> origin/direct-access-shared-calendar
[deleted] (none) -> origin/email-template-html-fragment
[deleted] (none) -> origin/enh/a11y-util
[deleted] (none) -> origin/enh/noid/iconfig
[deleted] (none) -> origin/enh/noid/use-taskprocessing-in-old-managers
[deleted] (none) -> origin/enhancement/caldav-resources-sync-command
[deleted] (none) -> origin/enhancement/typed-db-entity
[deleted] (none) -> origin/external-list-for
[deleted] (none) -> origin/extract-caldav-sharing-plugin
[deleted] (none) -> origin/feat-add-iavaialble-in-maintenance-mode
[deleted] (none) -> origin/feat/mail-admin-vue
[deleted] (none) -> origin/file-cache-insertion-atomic
[deleted] (none) -> origin/fix/44160/ctrl-f-trigger-global-search
[deleted] (none) -> origin/fix/files-non-visual-loading-info
[deleted] (none) -> origin/fix/header-styles
[deleted] (none) -> origin/fix/noid/identity-proof-key-checksum
[deleted] (none) -> origin/fix/user-settings-admin
[deleted] (none) -> origin/home-storage-lazy-datadir
[deleted] (none) -> origin/introduce/orm
[deleted] (none) -> origin/locate-key-fix
[deleted] (none) -> origin/mountcache-lazy-user
[deleted] (none) -> origin/multi-object-store
[deleted] (none) -> origin/remove_depreated_files
[deleted] (none) -> origin/setupmanager-lazy-user
[deleted] (none) -> origin/share-null-source
[deleted] (none) -> origin/storage-cache-init-in-transaction
[deleted] (none) -> origin/trashbin-skip-logging
[deleted] (none) -> origin/upload-chunk-locking
[deleted] (none) -> origin/use_HSTS
[deleted] (none) -> origin/user-files-debug-info
[deleted] (none) -> origin/work/sharing_trash
error: Your local changes to the following files would be overwritten by merge:
dist/4254-4254.js.map.license
dist/4696-4696.js.map.license
dist/5643-5643.js.map.license
Please commit your changes or stash them before you merge.
Aborting

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

fix(linkReferenceProvider): better size check
22bb42b
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>

julien-nc added enhancement 3. to review Waiting for reviews feature: previews and thumbnails labels Aug 30, 2024

julien-nc added this to the Nextcloud 31 milestone Aug 30, 2024

julien-nc requested review from juliusknorr, nickvergessen and sorbaugh August 30, 2024 09:00

backportbotBot added the backport-request label Aug 30, 2024

julien-nc enabled auto-merge August 30, 2024 10:04

julien-nc requested a review from mejo-August 30, 2024 10:05

AndyScherzinger approved these changes Aug 30, 2024
View reviewed changes

ChristophWurst approved these changes Sep 2, 2024
View reviewed changes

julien-nc merged commit 873c42b into masterSep 2, 2024

julien-nc deleted the fix/noid/link-ref-provider-size-check branch September 2, 2024 10:33

This was referenced Sep 3, 2024
[stable30] [LinkReferenceProvider] Better size check #47695
Merged
[stable29] [LinkReferenceProvider] Better size check #47696
Merged
[stable28] [LinkReferenceProvider] Better size check #47697
Merged
[stable27] [LinkReferenceProvider] Better size check #47698
Merged

joshtrichards mentioned this pull request Sep 13, 2024
[Bug]: references/resolved endoint runs into memory exhausted when targeted at big files #34720
Closed
9 tasks

nickvergessen mentioned this pull request Sep 13, 2024
fix(collaboration): Reduce timeouts to 3s for link reference connects #47948
Merged
4 tasks

skjnldsv mentioned this pull request Jan 7, 2025
31.0.0 beta 1 #50066
Merged

Navigation Menu

Uh oh!

Uh oh!

[LinkReferenceProvider] Better size check - #47627

[LinkReferenceProvider] Better size check#47627
julien-nc merged 1 commit into
masterfrom
fix/noid/link-ref-provider-size-check

julien-nc commented Aug 30, 2024

Uh oh!

julien-nc commented Aug 30, 2024

Uh oh!

julien-nc commented Aug 30, 2024

Uh oh!

julien-nc commented Aug 30, 2024

Uh oh!

julien-nc commented Aug 30, 2024

Uh oh!

backportbotBot commented Sep 2, 2024

Uh oh!

backportbotBot commented Sep 2, 2024

Uh oh!

backportbotBot commented Sep 2, 2024

Uh oh!

backportbotBot commented Sep 2, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

julien-nc commented Aug 30, 2024

Uh oh!

julien-nc commented Aug 30, 2024

Uh oh!

julien-nc commented Aug 30, 2024

Uh oh!

julien-nc commented Aug 30, 2024

Uh oh!

julien-nc commented Aug 30, 2024

Uh oh!

backportbotBot commented Sep 2, 2024

Uh oh!

backportbotBot commented Sep 2, 2024

Uh oh!

backportbotBot commented Sep 2, 2024

Uh oh!

backportbotBot commented Sep 2, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants