Uh oh!
There was an error while loading. Please reload this page.
refactor(style): Remove repeated semicolon - #47648
Conversation
c581af1 to
b31be49CompareThere was a problem hiding this comment.
The value is valid, line-height can just be a numeric factor.
This is essential for calculations of different elements with different font sizes, so this is just the relative line height.
This value default-line-height can be used on any element regardless if the element uses font-size: var(--default-font-size); or font-size: var(--font-size-small).
Instead if you need the line height of an element you do not need any variable, but simply can use 1lh this is the CSS unit for one line height of that element.
| */ | ||
| #body-public { | ||
| --footer-height: calc(var(--default-line-height) + 2 * var(--default-grid-baseline));; | ||
| --footer-height: calc(var(--default-line-height) + 2 * var(--default-grid-baseline)); |
There was a problem hiding this comment.
So instead you need to multiply the line height with the font size, or much easier:
| --footer-height: calc(var(--default-line-height) + 2 * var(--default-grid-baseline)); | |
| --footer-height: calc(1lh + 2 * var(--default-grid-baseline)); |
| &:has(.footer__legal-links), | ||
| &:has(.footer__simple-sign-up) { | ||
| --footer-height: calc(2 * var(--default-line-height) + 3 * var(--default-grid-baseline));; | ||
| --footer-height: calc(2 * var(--default-line-height) + 3 * var(--default-grid-baseline)); |
There was a problem hiding this comment.
| --footer-height: calc(2 * var(--default-line-height) + 3 * var(--default-grid-baseline)); | |
| --footer-height: calc(2lh + 3 * var(--default-grid-baseline)); |
b31be49 to
a8b9a96CompareSigned-off-by: Christopher Ng <chrng8@gmail.com>
a8b9a96 to
9f7d69fCompare
Summary
Checklist