Skip to content

fix(OCP): Fix Image interface - #47676

Merged
provokateurin merged 1 commit into
masterfrom
fix/ocp/image-interface
Sep 2, 2024
Merged

fix(OCP): Fix Image interface#47676
provokateurin merged 1 commit into
masterfrom
fix/ocp/image-interface

Conversation

@provokateurin

@provokateurinprovokateurin commented Sep 2, 2024

Copy link
Copy Markdown
Member

Summary

Using a private class in the public interface leads to no methods being resolved. Thus it needs to implement \OCP\IImage.
\OCP\IImage is also missing some methods that were relied on in OC_Image by other apps (e.g. Talk nextcloud/spreed#13197) and needed to be added.

Checklist

@provokateurinprovokateurin added bug 3. to review Waiting for reviews labels Sep 2, 2024
@provokateurinprovokateurin added this to the Nextcloud 31 milestone Sep 2, 2024
Comment threadlib/public/Image.php
Signed-off-by: provokateurin <kate@provokateurin.de>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@provokateurin@artonge@come-nc