Skip to content

[stable29] fix(settings): Hide forbidden UI elements for group managers - #47687

Merged
AndyScherzinger merged 2 commits into
stable29from
backport/29/ui-group-mgr
Sep 2, 2024
Merged

[stable29] fix(settings): Hide forbidden UI elements for group managers#47687
AndyScherzinger merged 2 commits into
stable29from
backport/29/ui-group-mgr

Conversation

@susnux

@susnuxsusnux commented Sep 2, 2024

Copy link
Copy Markdown
Contributor

Summary

  1. The "recent" accounts API only works for admin and delegated admin -> hide for group managers
  2. Group managers can not create new groups -> Hide the UI to add a new group for them
  3. Accounts created by group managers require one of the groups, which is managed by the group manager, assigned. So if the group manager only manageres a single group, we should preselect that group.

Checklist

@susnuxsusnux added bug 3. to review Waiting for reviews labels Sep 2, 2024
@susnuxsusnux added this to the Nextcloud 29.0.6 milestone Sep 2, 2024
@susnux
susnux requested review from a team, Pytal, artonge and szaimen and removed request for a teamSeptember 2, 2024 15:59
1. The "recent" accounts API only works for admin and delegated admin -> hide for group managers
2. Group managers can not create new groups -> Hide the UI to add a new group for them
3. Accounts created by group managers require one of the groups, which is managed by the group manager, assigned.
So if the group manager only manageres a single group, we should preselect that group.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@AndyScherzinger

Copy link
Copy Markdown
Member

/compile /

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@susnuxsusnux added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 2, 2024
@AndyScherzinger
AndyScherzinger merged commit 1f394cb into stable29Sep 2, 2024
@AndyScherzinger
AndyScherzinger deleted the backport/29/ui-group-mgr branch September 2, 2024 20:41
@blizzzblizzz mentioned this pull request Sep 3, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@susnux@AndyScherzinger@artonge@nextcloud-command