Skip to content

fix(files): undefined sidebar - #47738

Merged
skjnldsv merged 2 commits into
masterfrom
fix/sidebar-undefined
Sep 4, 2024
Merged

fix(files): undefined sidebar#47738
skjnldsv merged 2 commits into
masterfrom
fix/sidebar-undefined

Conversation

@skjnldsv

@skjnldsvskjnldsv commented Sep 4, 2024

Copy link
Copy Markdown
Member

If file doesn't exist, the Sidebar is not mounted, so refs.sidebar is undefined

<NcAppSidebarv-if="file"
ref="sidebar"

Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsvskjnldsv added bug 3. to review Waiting for reviews feature: files feature: file sidebar Related to the file sidebar component labels Sep 4, 2024
@skjnldsv
skjnldsv requested review from a team and blizzzSeptember 4, 2024 12:12
@skjnldsvskjnldsv self-assigned this Sep 4, 2024
@skjnldsv
skjnldsv requested review from Pytal, susnux and szaimen and removed request for a teamSeptember 4, 2024 12:12
@skjnldsv

Copy link
Copy Markdown
MemberAuthor

/backport to stable30

@skjnldsv

Copy link
Copy Markdown
MemberAuthor

/backport to stable29

@skjnldsv

Copy link
Copy Markdown
MemberAuthor

/backport to stable28

@susnux

Copy link
Copy Markdown
Contributor

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 4, 2024
@skjnldsv
skjnldsv merged commit 2d2a510 into masterSep 4, 2024
@skjnldsv
skjnldsv deleted the fix/sidebar-undefined branch September 4, 2024 14:50
@skjnldsv

Copy link
Copy Markdown
MemberAuthor

/backport to stable29

@backportbot

This comment was marked as resolved.

@skjnldsvskjnldsv mentioned this pull request Jan 7, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugfeature: file sidebarRelated to the file sidebar componentfeature: files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@skjnldsv@susnux@AndyScherzinger@miaulalala@provokateurin@nextcloud-command