Skip to content

fix(appstore): Cache apps.json also on dev instances - #47754

Merged
AndyScherzinger merged 1 commit into
masterfrom
fix/noid/cache-appstore-on-dev-instances
Sep 5, 2024
Merged

fix(appstore): Cache apps.json also on dev instances#47754
AndyScherzinger merged 1 commit into
masterfrom
fix/noid/cache-appstore-on-dev-instances

Conversation

@SystemKeeper

@SystemKeeperSystemKeeper commented Sep 4, 2024

Copy link
Copy Markdown
Contributor

Summary

Currently caching of appstore files is disabled as soon as we are running beta, daily or git channel. When we run the current master and open index.php/settings/apps/discover we hit

/**
* Returns the array with the entries on the appstore server
*
* @param bool [$allowUnstable] Allow unstable releases
* @return array
*/
publicfunctionget($allowUnstable = false) {
already 5 times, resulting in 5 requests to apps.json from the app store.

While it makes sense to have a shorter cache time for dev instances, we shouldn't omit all caching. This PR adds a 15 min caching (instead of 60 min on production) to dev instances.

Checklist

@SystemKeeperSystemKeeper self-assigned this Sep 4, 2024
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
@SystemKeeper
SystemKeeperforce-pushed the fix/noid/cache-appstore-on-dev-instances branch from 39b37d8 to b2c2c93CompareSeptember 4, 2024 19:57
@SystemKeeper

Copy link
Copy Markdown
ContributorAuthor

/backport! to stable30

@SystemKeeper

Copy link
Copy Markdown
ContributorAuthor

/backport! to stable29

@SystemKeeper

Copy link
Copy Markdown
ContributorAuthor

/backport! to stable28

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@SystemKeeper@bigcat88@skjnldsv@provokateurin@AndyScherzinger