Uh oh!
There was an error while loading. Please reload this page.
fix(OC): Use @inheritDoc for OCP implementations - #47798
Draft
provokateurin wants to merge 3 commits into
Draft
Conversation
provokateurinforce-pushed
the
fix/oc/inheritdoc
branch
from
September 6, 2024 09:44
4efdbc7 to
5c04de5CompareSigned-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurinforce-pushed
the
fix/oc/inheritdoc
branch
from
September 9, 2024 09:11
5c04de5 to
007be83Comparekesselb
reviewed
Sep 9, 2024
| /** | ||
| * SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors | ||
| * SPDX-License-Identifier: AGPL-3.0-only |
Contributor
There was a problem hiding this comment.
Suggested change
| * SPDX-License-Identifier: AGPL-3.0-only | |
| * SPDX-License-Identifier: AGPL-3.0-or-later |
MemberAuthor
There was a problem hiding this comment.
The script will be removed from the PR anyway. When it is fixed once it is enforced by psalm so the script will never be needed again as everyone has to set the correct doc blocks in their PRs already.
MemberAuthor
There was a problem hiding this comment.
No worries, I never said what is going to happen with this PR.
I plan to fix the issues that were found in separate PRs and once that is done we can merge the PR.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ensures interface and implementation align. A step towards tightening OCP types.
TODO:
Check class docsNot possible because sometimes class docs need special annotations like@psalm-import-typeor@template-implementsChecklist