Uh oh!
There was an error while loading. Please reload this page.
fix(TaskProcessing): increase error_message column length - #47801
Merged
Conversation
kyteinsky
commented
Sep 6, 2024
ContributorAuthor
There needs to be a Version31000 migration for NC 31, yes? |
marcelklehr
commented
Sep 6, 2024
Member
I don't think so 🤔 |
marcelklehr
approved these changes
Sep 6, 2024
marcelklehr
commented
Sep 6, 2024
Member
Ah, this is for stable30? |
marcelklehr
commented
Sep 6, 2024
Member
Would perhaps be better to submit this PR against master and then backport? |
bigcat88
approved these changes
Sep 6, 2024
kyteinsky
commented
Sep 6, 2024
ContributorAuthor
Yup, now that a separate PR is not required. |
Uh oh!
There was an error while loading. Please reload this page.
kyteinskyforce-pushed
the
fix/taskproc/error-msg
branch
from
September 6, 2024 12:17
ee2329a to
0a01b99Comparekyteinsky
requested review from
Altahrim, Antreesy, ArtificialOwl, ChristophWurst, JuliaKirschenheuter, Pytal, artonge, blizzz, come-nc, icewind1991, juliusknorr, miaulalala, nickvergessen, provokateurin, skjnldsv, st3iny, susnux and szaimen
as code ownersSeptember 6, 2024 12:17
kyteinsky
removed request for
Antreesy, GretaD, come-nc, danxuliu, datenangebot, edward-ly, hamza221, kesselb, luka-nextcloud, mejo-, provokateurin, szaimen and tcitworldSeptember 6, 2024 12:18
kyteinsky
commented
Sep 6, 2024
ContributorAuthor
oops, sorry, changed base branch 🙈 |
kyteinskyforce-pushed
the
fix/taskproc/error-msg
branch
from
September 6, 2024 12:21
0a01b99 to
0812054Compareprovokateurin
requested changes
Sep 6, 2024
provokateurin
left a comment
Member
There was a problem hiding this comment.
All the composer changes need to be reverted (except for the autoload_*.php ones)
Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>
Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>
kyteinskyforce-pushed
the
fix/taskproc/error-msg
branch
from
September 6, 2024 12:33
0812054 to
31a983aComparekyteinsky
commented
Sep 6, 2024
ContributorAuthor
done, thanks Kate! |
provokateurin
approved these changes
Sep 6, 2024
kyteinsky
commented
Sep 6, 2024
ContributorAuthor
/backport to stable30 |
susnux
approved these changes
Sep 6, 2024
| use OCP\Migration\IOutput; | ||
| use OCP\Migration\SimpleMigrationStep; | ||
| #[ModifyColumn(table: 'taskprocessing_tasks', name: 'error_message', description: 'Increase column length to 4000 bytes to support longer error messages')] |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Increase the length of the error message that can be stored and truncate it before updating the db.
And make the errors more visible since the previous error message was masked by throwing from an exception.
Checklist