Skip to content

fix(files_sharing): password checkbox and labels in link share - #47807

Merged
ShGKme merged 3 commits into
masterfrom
fix/files_sharing--password-label
Sep 9, 2024
Merged

fix(files_sharing): password checkbox and labels in link share#47807
ShGKme merged 3 commits into
masterfrom
fix/files_sharing--password-label

Conversation

@ShGKme

Copy link
Copy Markdown
Contributor

Summary

In link share creation:

  • When "Always ask for a password" is enabled but not enforced, there was no checkbox to enable/disable password
    • NcActionCheckbox component wasn't imported and registered - fixed
  • In both password and date inputs, there were no labels but just a text in the previous item
    • NcActionInput content was used instead of a label prop - replaced
    • Also, removed unneeded NcActionText in flavor of label

Screenshots

Enforced date - worked but no accessible label

BeforeAfter
imageimage

Enforced password - worked but no accessible label

BeforeAfter
imageimage

Ask for a password - had no label at all and no checkbox to re-enable

BeforeAfter
before-passwordafter-password

Checklist

@ShGKmeShGKme added this to the Nextcloud 31 milestone Sep 6, 2024
@ShGKmeShGKme self-assigned this Sep 6, 2024
@ShGKme

Copy link
Copy Markdown
ContributorAuthor

/backport to stable30

@ShGKme

Copy link
Copy Markdown
ContributorAuthor

/backport to stable29

@ShGKme
ShGKme requested review from nfebe, skjnldsv and susnux and removed request for susnuxSeptember 6, 2024 15:11
@ShGKme
ShGKme requested a review from artongeSeptember 9, 2024 09:03
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
ShGKmeforce-pushed the fix/files_sharing--password-label branch from c6be59f to 692a8edCompareSeptember 9, 2024 13:03
@ShGKme

ShGKme commented Sep 9, 2024

Copy link
Copy Markdown
ContributorAuthor

Rebased on master to resolve conflicts.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@ShGKme@susnux@artonge