Skip to content

fix(appstore): return if appstore is manually disabled - #47834

Merged
skjnldsv merged 2 commits into
masterfrom
retAppsManDis
Sep 10, 2024
Merged

fix(appstore): return if appstore is manually disabled#47834
skjnldsv merged 2 commits into
masterfrom
retAppsManDis

Conversation

@solracsf

@solracsfsolracsf commented Sep 9, 2024

Copy link
Copy Markdown
Member

Checklist

@solracsfsolracsf added the 3. to review Waiting for reviews label Sep 9, 2024
@solracsfsolracsf added this to the Nextcloud 31 milestone Sep 9, 2024
@solracsf

solracsf commented Sep 9, 2024

Copy link
Copy Markdown
MemberAuthor

/backport to stable30

@solracsf

solracsf commented Sep 9, 2024

Copy link
Copy Markdown
MemberAuthor

/backport to stable29

@solracsf

solracsf commented Sep 9, 2024

Copy link
Copy Markdown
MemberAuthor

/backport to stable28

@solracsf
solracsfforce-pushed the retAppsManDis branch 2 times, most recently from f6a0a38 to e64894dCompareSeptember 9, 2024 07:46
github-advanced-security[bot]
github-advanced-securityAI found potential problems Sep 9, 2024
View reviewed changes
Comment threadlib/private/App/AppStore/Fetcher/AppFetcher.php Fixed
Comment threadlib/private/App/AppStore/Fetcher/AppFetcher.php Fixed
@solracsf
fix(appstore): return if appstore is manually disabled
2ac8d9a
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
fix: camel case
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
fix: log a debug log
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
fix: typing
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
fix: typo
fix: typing
@susnux
susnux requested review from a team, icewind1991 and nfebe and removed request for a team and nickvergessenSeptember 9, 2024 14:47
nickvergessen
nickvergessen approved these changes Sep 10, 2024
View reviewed changes
Comment threadlib/private/App/AppStore/Fetcher/AppFetcher.php Outdated
@skjnldsv@nickvergessen
fix(appstore): disabled appstore log level bump from debug to info
4d3168f
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 10, 2024
@skjnldsv
skjnldsv merged commit 0858ff7 into masterSep 10, 2024
@skjnldsv
skjnldsv deleted the retAppsManDis branch September 10, 2024 14:31
@backportbotbackportbotBot mentioned this pull request Sep 10, 2024
Merged
This was referenced Sep 10, 2024
Merged
Merged
@ShGKmeShGKme mentioned this pull request Sep 17, 2024
Merged
4 tasks
@skjnldsvskjnldsv mentioned this pull request Jan 7, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessennickvergessennickvergessen approved these changes
@susnuxsusnuxsusnux approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes
@icewind1991icewind1991Awaiting requested review from icewind1991icewind1991 is a code owner automatically assigned from nextcloud/server-backend
@nfebenfebeAwaiting requested review from nfebenfebe is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finish

Projects

None yet

Milestone

Nextcloud 31

Development

Successfully merging this pull request may close these issues.

[Bug]: set 'appstoreenabled' => false, still show Warning logging

5 participants

@solracsf@nickvergessen@susnux@skjnldsv@github-advanced-security