Uh oh!
There was an error while loading. Please reload this page.
fix(files): Reset context menu position on close - #47848
Merged
Merged
Conversation
susnux
requested review from
artonge and szaimen
and removed request for
a teamSeptember 9, 2024 13:39
susnux
commented
Sep 9, 2024
ContributorAuthor
/backport to stable30 |
susnux
commented
Sep 9, 2024
ContributorAuthor
/backport to stable29 |
susnux
commented
Sep 9, 2024
ContributorAuthor
/backport to stable28 |
marcelklehr
approved these changes
Sep 9, 2024
artonge
approved these changes
Sep 9, 2024
susnux
commented
Sep 9, 2024
ContributorAuthor
/compile |
susnux
enabled auto-merge
September 9, 2024 14:02
marcelklehr
commented
Sep 10, 2024
Member
Conflicts :/ |
* Resolves#46934 Ensure that after a right-click the context menu position is resetted, so that pressing the "actions"-menu button it is displayed on the correct location. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnuxforce-pushed
the
fix/files-context-menu
branch
from
September 10, 2024 11:19
282970c to
49c2d18Comparesusnux
commented
Sep 10, 2024
ContributorAuthor
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
This was referenced Sep 10, 2024
provokateurin
commented
Sep 11, 2024
Member
@susnux I think this broke groupfolders cypress with the following error message: |
Member
See https://github.com/nextcloud/groupfolders/actions/runs/10796406217/job/29947702773?pr=3201 for example (I can also reproduce it locally on the master branch of groupfolders). |
Uh oh!
There was an error while loading. Please reload this page.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ensure that after a right-click the context menu position is reset, so that pressing the "actions"-menu button it is displayed on the correct location.
Screen recording
Bildschirmaufnahme_20240909_153456.webm
Checklist