Skip to content

fix(files): Add more visual move / copy notification - #47910

Merged
kesselb merged 1 commit into
masterfrom
fix/files-add-move-info
Sep 30, 2024
Merged

fix(files): Add more visual move / copy notification#47910
kesselb merged 1 commit into
masterfrom
fix/files-add-move-info

Conversation

@susnux

@susnuxsusnux commented Sep 11, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

This adds loading toast notification while the move operation is running.

Screen recording

Bildschirmaufnahme_20240911_222420.webm

Checklist

@susnuxsusnux added 3. to review Waiting for reviews feature: files labels Sep 11, 2024
@susnux
susnux requested review from a team, kesselb and marcoambrosiniSeptember 11, 2024 20:32
@susnux
susnux requested review from nfebe and szaimen and removed request for a teamSeptember 11, 2024 20:32
@susnuxsusnux added this to the Nextcloud 31 milestone Sep 11, 2024
@susnux

susnux commented Sep 11, 2024

Copy link
Copy Markdown
ContributorAuthor

/backport to stable30

@susnux

susnux commented Sep 11, 2024

Copy link
Copy Markdown
ContributorAuthor

/backport to stable29

@susnux

susnux commented Sep 11, 2024

Copy link
Copy Markdown
ContributorAuthor

/backport to stable28

@kesselb

This comment was marked as resolved.

Sign in to view
kesselb
kesselb reviewed Sep 11, 2024
View reviewed changes
Comment threadapps/dav/lib/Connector/Sabre/FilesPlugin.php Outdated
marcoambrosini
marcoambrosini reviewed Sep 12, 2024
View reviewed changes

@marcoambrosinimarcoambrosini left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, can we use a loader component instead and feed the actual progress of the operation to it?

I had a mockup for something similar a few months ago, but this is a much simpler solution that does a big part of the job.

@skjnldsv

skjnldsv commented Sep 12, 2024

Copy link
Copy Markdown
Member

Very nice, can we use a loader component instead and feed the actual progress of the operation to it?

That is much more work, and should be scheduled by a team lead :)

susnux
susnux commented Sep 26, 2024
View reviewed changes
Comment threadapps/files/css/files.scss Outdated
@susnux
susnuxforce-pushed the fix/files-add-move-info branch from 7fd28ce to 5571372CompareSeptember 26, 2024 18:33
@kesselb

kesselb commented Sep 30, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Thank you 👍

It's not ideal that for every selected file a toast is shown, but still better than before 🙏

@susnux@kesselb
fix(files): Add more visual move / copy notification
d97e17b
* Resolves: #46645
This adds loading toast notification while the move operation is running.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@kesselb
kesselbforce-pushed the fix/files-add-move-info branch from 5571372 to d97e17bCompareSeptember 30, 2024 11:33
@kesselb

kesselb commented Sep 30, 2024

Copy link
Copy Markdown
Contributor

Rebase + Recompile

@kesselb
kesselb merged commit b6a23b2 into masterSep 30, 2024
@kesselb
kesselb deleted the fix/files-add-move-info branch September 30, 2024 12:06
This was referenced Sep 30, 2024
Merged
Merged
Merged
@skjnldsvskjnldsv mentioned this pull request Jan 7, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kesselbkesselbkesselb approved these changes
@marcoambrosinimarcoambrosinimarcoambrosini approved these changes
@skjnldsvskjnldsvAwaiting requested review from skjnldsvskjnldsv is a code owner
@nfebenfebeAwaiting requested review from nfebenfebe is a code owner automatically assigned from nextcloud/server-frontend
@szaimenszaimenAwaiting requested review from szaimenszaimen is a code owner automatically assigned from nextcloud/server-frontend

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsfeature: files

Projects

None yet

Milestone

Nextcloud 31

Development

Successfully merging this pull request may close these issues.

[Bug]: No visual feedback for move operations

4 participants

@susnux@kesselb@skjnldsv@marcoambrosini