🥅 — Catch MaxInstancesExceededException on calendar events

[ldidry]

Summary

When an event is recurring and has a huge number (more than 3500) of occurrences, you couldn’t see the calendar in web Interface.

Generally, you have this sort of event when using recurrence option and no end condition (see #29896).

The fetching request got this as response:

<?xml version="1.0" encoding="utf-8"?>
<d:errorxmlns:d="DAV:"xmlns:s="http://sabredav.org/ns">
<s:exception>Sabre\VObject\Recur\MaxInstancesExceededException</s:exception>
<s:message>Recurring events are only allowed to generate 3500</s:message>
</d:error>

Catching the Sabre\VObject\Recur\MaxInstancesExceededException allows to see the calendar.

Similar to #43647, #34442 and #29896

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes (irrelevant)
• Documentation (manuals or wiki) has been updated or is not required (irrelevant)
• Backports requested where applicable (ex: critical bugfixes)

/backport to stable28
/backport to stable29
/backport to stable30

[miaulalala]

LGTM! Thanks for your PR!

[ChristophWurst]

Looks good

This is best reviewed as https://github.com/nextcloud/server/pull/47924/files?w=1

The admin can't do anything about this error. Lowering the log level to warning could make sense.

[tcitworld]

The admin can't do anything about this error.

Well, one can add UNTIL parameters in the calendar data. But yeah, warning might be better.

[tcitworld]

/backport to stable28

[tcitworld]

/backport to stable29

[tcitworld]

/backport to stable30

[ldidry]

I changed the log level to warning, as suggested.

[susnux]

@ldidry could you adjust your commit message to follow conventional commits?
(something like: fix(dav): catch `MaxInstancesExceededException` on calendar events )

[ldidry]

Sure. Done.

[miaulalala]

Last issue @ldidry - can you please run composer cs:fix so that the linter is happy?

You can ignore cypress and the performance tests.

[ldidry]

Done

[miaulalala]

@skjnldsv can you force merge? Cypress and Perf is not running bc fork

[welcome]

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

[tcitworld]

/backport to stable29

[tcitworld]

/backport to stable30

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)