Uh oh!
There was an error while loading. Please reload this page.
[stable29] fix(config): Throw PreconditionException always when it didn't match - #47941
Merged
Conversation
Previously even when the precondition did not match, the call "passed" when the after value was the expected one. This however can lead to race conditions, duplicate code excutions and other things. Signed-off-by: Joas Schilling <coding@schilljs.com>
| if ($prevValue === (string)$value) { | ||
| return; | ||
| } elseif ($preCondition !== null && $prevValue !== (string)$preCondition) { | ||
| if ($preCondition !== null && $prevValue !== (string)$preCondition) { |
Check notice
Code scanning / Psalm
RedundantCastGivenDocblockType
artonge
approved these changes
Sep 13, 2024
nickvergessen
approved these changes
Sep 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #47933