Skip to content

fix(files_external): broken credentials dialog - #47945

Merged
skjnldsv merged 2 commits into
masterfrom
fix/external-storage-creds
Sep 13, 2024
Merged

fix(files_external): broken credentials dialog#47945
skjnldsv merged 2 commits into
masterfrom
fix/external-storage-creds

Conversation

@skjnldsv

Copy link
Copy Markdown
Member

The browsers behavior changed and some stopped prompting the native browser auth dialog on xhr requests.

This replaces it with a proper dialog.
Fix#44497

2024-09-13_12-00

@skjnldsvskjnldsv added this to the Nextcloud 31 milestone Sep 13, 2024
@skjnldsv
skjnldsv requested review from a team and provokateurinSeptember 13, 2024 12:01
@skjnldsvskjnldsv self-assigned this Sep 13, 2024
@skjnldsv
skjnldsv requested review from Pytal, artonge and susnux and removed request for a teamSeptember 13, 2024 12:01

@susnuxsusnux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Comment threadapps/files_external/src/views/CredentialsDialog.vue Outdated
@skjnldsv
skjnldsvforce-pushed the fix/external-storage-creds branch from 730fd73 to ff8583cCompareSeptember 13, 2024 12:30
@skjnldsv

Copy link
Copy Markdown
MemberAuthor

/compile rebase /

skjnldsvand others added 2 commits September 13, 2024 14:32
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@skjnldsv
skjnldsv merged commit 032f17c into masterSep 13, 2024
@skjnldsv
skjnldsv deleted the fix/external-storage-creds branch September 13, 2024 14:57
@skjnldsv

Copy link
Copy Markdown
MemberAuthor

/backport to stable30

@skjnldsv

Copy link
Copy Markdown
MemberAuthor

/backport to stable29

@skjnldsv

Copy link
Copy Markdown
MemberAuthor

/backport to stable28

@skjnldsv

Copy link
Copy Markdown
MemberAuthor

/backport 0f519f4 to stable30

@skjnldsv

Copy link
Copy Markdown
MemberAuthor

/backport 0f519f4 to stable29

@skjnldsv

Copy link
Copy Markdown
MemberAuthor

/backport 0f519f4 to stable28

@backportbot

Copy link
Copy Markdown

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30
# Create the new backport branch
git checkout -b backport/47945/stable30
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts, resolve them
git cherry-pick 0f519f4
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/47945/stable30

Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/47945/stable30."}


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot

Copy link
Copy Markdown

The backport to stable29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/47945/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts, resolve them
git cherry-pick 0f519f4
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/47945/stable29

Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/47945/stable29."}


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot

Copy link
Copy Markdown

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30
# Create the new backport branch
git checkout -b backport/47945/stable30
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts, resolve them
git cherry-pick 0f519f4
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/47945/stable30

Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/47945/stable30."}


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot

Copy link
Copy Markdown

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b backport/47945/stable28
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts, resolve them
git cherry-pick 0f519f4
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/47945/stable28

Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/47945/stable28."}


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Enter missing credentials for external storage

4 participants

@skjnldsv@susnux@provokateurin@nextcloud-command