Skip to content

fix(files): Adjust Cache::searchQuery() parameter name to match interface - #47954

Merged
provokateurin merged 1 commit into
masterfrom
fix/files/cache-search-query-parameter-name
Sep 13, 2024
Merged

fix(files): Adjust Cache::searchQuery() parameter name to match interface#47954
provokateurin merged 1 commit into
masterfrom
fix/files/cache-search-query-parameter-name

Conversation

@provokateurin

@provokateurinprovokateurin commented Sep 13, 2024

Copy link
Copy Markdown
Member

Summary

publicfunctionsearchQuery(ISearchQuery$query);

Checklist

…face
Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurinprovokateurin added 3. to review Waiting for reviews technical debt 🧱 🤔🚀 labels Sep 13, 2024
@provokateurinprovokateurin added this to the Nextcloud 31 milestone Sep 13, 2024
@provokateurin
provokateurin requested a review from a teamSeptember 13, 2024 16:15
@provokateurin

Copy link
Copy Markdown
MemberAuthor

/backport to stable30

@provokateurin

Copy link
Copy Markdown
MemberAuthor

/backport to stable29

@provokateurin

Copy link
Copy Markdown
MemberAuthor

/backport to stable28

@susnuxsusnux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there no psalm warning for this?

@provokateurin

Copy link
Copy Markdown
MemberAuthor

There is, but it was hidden by the baseline :/

@provokateurin

Copy link
Copy Markdown
MemberAuthor

Can someone force merge? Cypress fails hard for unknown reason and this change can not possibly affect cypress results anyway.

@provokateurin
provokateurin merged commit 80f3227 into masterSep 13, 2024
@provokateurin
provokateurin deleted the fix/files/cache-search-query-parameter-name branch September 13, 2024 16:59
@backportbot

Copy link
Copy Markdown

The backport to stable29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/47954/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts, resolve them
git cherry-pick 714671a8
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/47954/stable29

Error: Failed to push branch backport/47954/stable29: fatal: could not read Username for 'https://github.com': No such device or address


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@provokateurin

Copy link
Copy Markdown
MemberAuthor

/backport to stable29

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewstechnical debt🧱 🤔🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@provokateurin@susnux@artonge