Uh oh!
There was an error while loading. Please reload this page.
[stable30] feat: Reset route if neither the Viewer of the Sidebar is open - #48000
Merged
Conversation
skjnldsv
requested changes
Sep 15, 2024
skjnldsv
left a comment
Member
There was a problem hiding this comment.
Blocking, opening Viewer seems to change dir to root
artongeforce-pushed
the
backport/47920/stable30
branch
from
September 16, 2024 09:17
f57d752 to
ced43a1Compareartonge
marked this pull request as ready for review
September 16, 2024 09:17
artonge
approved these changes
Sep 16, 2024
When the viewer or the sidebar is opened, we add the fileid to the route. When both of them are closed, we do not remove the fileid from the route. This means that, upon reload, the sidebar will be opened even though it was closed previously. This PR ensure that the fileid is removed from the route when both the Sidebar and the Viewer are closed. Signed-off-by: Louis Chemineau <louis@chmn.me>
artongeforce-pushed
the
backport/47920/stable30
branch
from
September 16, 2024 09:18
ced43a1 to
2e5cab0Compareartonge
commented
Sep 16, 2024
Collaborator
Was due to the missing dot 🙈 |
Signed-off-by: Louis Chemineau <louis@chmn.me>
artongeforce-pushed
the
backport/47920/stable30
branch
from
September 16, 2024 09:53
2e5cab0 to
f44c76eCompareartonge
enabled auto-merge
September 16, 2024 12:04
skjnldsv
approved these changes
Sep 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #47920
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.