Uh oh!
There was an error while loading. Please reload this page.
fix(Storage\Local): Do not call getSourcePath() on SplFileInfo - #48015
Merged
provokateurin merged 1 commit intoSep 15, 2024
Conversation
Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin
requested review from
a team, icewind1991, miaulalala, sorbaugh and yemkareems
and removed request for
a teamSeptember 15, 2024 13:40
provokateurin
commented
Sep 15, 2024
MemberAuthor
/backport to stable30 |
provokateurin
commented
Sep 15, 2024
MemberAuthor
/backport to stable29 |
provokateurin
commented
Sep 15, 2024
MemberAuthor
/backport to stable28 |
icewind1991
approved these changes
Sep 15, 2024
sorbaugh
approved these changes
Sep 15, 2024
provokateurin
enabled auto-merge
September 15, 2024 14:46
provokateurin
deleted the
fix/storage-local/get-source-path-spl-file-info
branch
September 15, 2024 14:50
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#47984
Summary
getSourcePath expects a string and with SplInfoFile we already have the full path on the disk so the call is unnecessary in the first place.
Checklist