Uh oh!
There was an error while loading. Please reload this page.
fix(settings): disable Discover when appstore is disabled - #48090
Merged
ShGKme merged 2 commits intoSep 17, 2024
Conversation
ShGKme
requested review from
artonge and skjnldsv
and removed request for
a teamSeptember 16, 2024 13:55
ShGKme
commented
Sep 16, 2024
ContributorAuthor
/backport to stable30 |
ShGKme
commented
Sep 16, 2024
ContributorAuthor
/backport to stable30 |
ShGKme
commented
Sep 16, 2024
ContributorAuthor
/backport to stable29 |
susnux
reviewed
Sep 16, 2024
| import { loadState } from '@nextcloud/initial-state' | ||
| import type { RouteConfig } from 'vue-router' |
Contributor
There was a problem hiding this comment.
Types 🆙
Suggested change
| import{loadState}from'@nextcloud/initial-state' | |
| importtype{RouteConfig}from'vue-router' | |
| importtype{RouteConfig}from'vue-router' | |
| import{loadState}from'@nextcloud/initial-state' |
ContributorAuthor
There was a problem hiding this comment.
ESLint does not complain ._.
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
ShGKmeforce-pushed
the
fix/settings--disable-discover-when-app-store-is-disabled
branch
from
September 16, 2024 14:30
2465ed0 to
5ac467bComparenickvergessen
approved these changes
Sep 16, 2024
susnux
approved these changes
Sep 16, 2024
ShGKme
enabled auto-merge
September 16, 2024 15:47
ShGKme
deleted the
fix/settings--disable-discover-when-app-store-is-disabled
branch
September 17, 2024 08:31
This was referenced Sep 17, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Even when the App Store is disabled, the default page (also listed in the navigation) is Discovery, which doesn't work. And when there is no internet, it results in error: "Avertissement appstoreFetcher Could not get apps from the appstore".
Solution — if the app store is disabled:
P.S. It is still possible to open any category, including supported or non-existed by direct link and see an error. Might make sense to explicitly define the list of available categories and check before route enter/update.
Checklist