Skip to content

[stable30] feat(share): ensure unique share tokens - #48142

Merged
nickvergessen merged 1 commit into
stable30from
backport/47265/stable30
Sep 26, 2024
Merged

[stable30] feat(share): ensure unique share tokens#48142
nickvergessen merged 1 commit into
stable30from
backport/47265/stable30

Conversation

@nickvergessen

@nickvergessennickvergessen commented Sep 17, 2024

Copy link
Copy Markdown
Member
  • check for token collisions and retry up to three times.
  • abort with an error if maximum token length is reached without finding a unique token.

Backport of #47265

Checklist

@nickvergessennickvergessen added this to the Nextcloud 30.0.1 milestone Sep 17, 2024
@nickvergessennickvergessen self-assigned this Sep 17, 2024
@nickvergessen

nickvergessen commented Sep 17, 2024

Copy link
Copy Markdown
MemberAuthor

/backport to stable29

@nickvergessen

nickvergessen commented Sep 17, 2024

Copy link
Copy Markdown
MemberAuthor

/backport to stable28

@nickvergessen

nickvergessen commented Sep 17, 2024

Copy link
Copy Markdown
MemberAuthor

/backport to stable28

@nickvergessen

nickvergessen commented Sep 17, 2024

Copy link
Copy Markdown
MemberAuthor

/backport to stable27

@nickvergessen

nickvergessen commented Sep 17, 2024

Copy link
Copy Markdown
MemberAuthor

/backport to stable26

@nickvergessen

nickvergessen commented Sep 17, 2024

Copy link
Copy Markdown
MemberAuthor

/backport to stable25

github-advanced-security[bot]
github-advanced-securityAI found potential problems Sep 17, 2024
View reviewed changes
Comment threadlib/private/Share20/Manager.php Fixed
@ernolf@nickvergessen
fix(share): Ensure unique share tokens
0551919
- check for token collisions and retry up to three times.
- throw after 3 attempts without finding a unique token.
Signed-off-by: ernolf <raphael.gradenwitz@googlemail.com>
ernolf
ernolf approved these changes Sep 25, 2024
View reviewed changes

@ernolfernolf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works!

@nickvergessen
nickvergessen requested review from a team, ArtificialOwl, come-nc and yemkareems and removed request for a teamSeptember 25, 2024 10:05
@nickvergessen
nickvergessen merged commit 5cc1fb9 into stable30Sep 26, 2024
@nickvergessen
nickvergessen deleted the backport/47265/stable30 branch September 26, 2024 10:33
@nickvergessennickvergessen changed the title [stable30] feat(share): ensure unique share tokens with dynamic length adjustment[stable30] feat(share): ensure unique share tokensSep 26, 2024
This was referenced Sep 26, 2024
Merged
Merged
Merged
This was referenced Sep 26, 2024
Merged
Merged
@AltahrimAltahrim mentioned this pull request Oct 1, 2024
Merged
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ernolfernolfernolf approved these changes
@come-nccome-nccome-nc approved these changes
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr
@ArtificialOwlArtificialOwlAwaiting requested review from ArtificialOwlArtificialOwl was automatically assigned from nextcloud/server-backend
@yemkareemsyemkareemsAwaiting requested review from yemkareemsyemkareems was automatically assigned from nextcloud/server-backend

Assignees

@nickvergessennickvergessen

Labels

3. to reviewWaiting for reviewsbugfeature: sharing

Projects

None yet

Milestone

Nextcloud 30.0.1

Development

Successfully merging this pull request may close these issues.

4 participants

@nickvergessen@ernolf@github-advanced-security@come-nc