Uh oh!
There was an error while loading. Please reload this page.
Object store move fixes and more - #48160
Merged
Merged
Conversation
icewind1991
requested review from
a team, artonge, provokateurin and yemkareems
and removed request for
a teamSeptember 18, 2024 09:21
icewind1991force-pushed
the
object-store-move-fixes
branch
from
September 18, 2024 09:23
0e8eac6 to
4baf83fCompareyemkareems
approved these changes
Sep 18, 2024
provokateurin
approved these changes
Sep 18, 2024
come-nc
approved these changes
Sep 18, 2024
provokateurin
commented
Sep 18, 2024
Member
It seems to uncover a lot of different problems according to the tests. |
…FromStorage Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991force-pushed
the
object-store-move-fixes
branch
from
September 18, 2024 11:55
4baf83f to
8b06ce1CompareSigned-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991force-pushed
the
object-store-move-fixes
branch
from
September 18, 2024 12:11
8b06ce1 to
431846bCompareicewind1991force-pushed
the
object-store-move-fixes
branch
from
September 18, 2024 12:28
431846b to
bdaac72Comparecfiehe
commented
Sep 18, 2024
@icewind1991 |
icewind1991force-pushed
the
object-store-move-fixes
branch
from
September 18, 2024 13:07
bdaac72 to
0792108Compareicewind1991
commented
Sep 18, 2024
MemberAuthor
phpunit is green now |
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991force-pushed
the
object-store-move-fixes
branch
from
September 18, 2024 14:10
f325c71 to
1ad58d6Compareprovokateurin
commented
Sep 18, 2024
Member
Seems like the sharding bug is back on oracle. |
icewind1991
commented
Sep 18, 2024
MemberAuthor
from what I can tell |
icewind1991
commented
Sep 19, 2024
MemberAuthor
/backport to stable30 |
2 tasks
This was referenced Sep 19, 2024
Closed
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes some issues in cross-storage moves with object storage found by the tests added in #47986
I'm not sure how much of these issues would occur in the real world or only in the artificial test situations.
Comes with a bonus lower overhead
file_put_contentsimplementation.Fixes#48169