Uh oh!
There was an error while loading. Please reload this page.
fix: Don't crash if disabled user is missing in the database - #48207
Merged
artonge merged 1 commit intoSep 23, 2024
Merged
Conversation
artonge
commented
Sep 19, 2024
CollaboratorAuthor
/backport to stable30 |
artonge
commented
Sep 19, 2024
CollaboratorAuthor
/backport to stable29 |
artonge
commented
Sep 19, 2024
CollaboratorAuthor
/backport to stable28 |
come-nc
approved these changes
Sep 19, 2024
come-nc
requested changes
Sep 19, 2024
come-nc
left a comment
Contributor
There was a problem hiding this comment.
Actually, please throw a NoUserException and catch that, using try/catch for a typeerror is a bad idea.
artongeforce-pushed
the
artonge/fix/prevent_missing_users_from_crashing_disabled_users_search
branch
from
September 19, 2024 13:55
eaaad6a to
5a951faCompareAltahrim
approved these changes
Sep 19, 2024
come-nc
approved these changes
Sep 19, 2024
artongeforce-pushed
the
artonge/fix/prevent_missing_users_from_crashing_disabled_users_search
branch
2 times, most recently
from
September 20, 2024 09:11
88a9483 to
1fa3842Compareartongeforce-pushed
the
artonge/fix/prevent_missing_users_from_crashing_disabled_users_search
branch
from
September 20, 2024 09:26
cfb20c0 to
e0ed466Compareartongeforce-pushed
the
artonge/fix/prevent_missing_users_from_crashing_disabled_users_search
branch
7 times, most recently
from
September 20, 2024 14:48
c99c43a to
78bfecbCompareartonge
enabled auto-merge
September 20, 2024 15:38
Signed-off-by: Louis Chemineau <louis@chmn.me>
artongeforce-pushed
the
artonge/fix/prevent_missing_users_from_crashing_disabled_users_search
branch
from
September 23, 2024 08:40
78bfecb to
22d5d29Compareartonge
deleted the
artonge/fix/prevent_missing_users_from_crashing_disabled_users_search
branch
September 23, 2024 10:03
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the user is missing in the DB, then
getEMailAddresswill throw as user will benull.