Uh oh!
There was an error while loading. Please reload this page.
fix: improve moving object store items to trashbin - #48224
Merged
Conversation
icewind1991
requested review from
a team, ArtificialOwl, provokateurin and yemkareems
and removed request for
a teamSeptember 19, 2024 17:35
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
icewind1991force-pushed
the
object-store-trash-move
branch
from
September 19, 2024 18:31
95427ec to
938a79aCompareprovokateurin
approved these changes
Sep 19, 2024
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991force-pushed
the
object-store-trash-move
branch
from
September 19, 2024 19:01
938a79a to
42ea824Compareicewind1991
commented
Sep 20, 2024
MemberAuthor
/backport to stable30 |
come-nc
approved these changes
Sep 20, 2024
2 tasks
icewind1991
commented
Oct 4, 2024
MemberAuthor
Added to #48488 for the 29 backport |
icewind1991
commented
Oct 4, 2024
MemberAuthor
Added to #48213 for the 28 backport |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With various changes to how objectstore
moveFromStorageworks since this code was last touched. The following version should be "more correct".