Uh oh!
There was an error while loading. Please reload this page.
new occ commands to manage system-tags for files - #48277
Conversation
| return 1; | ||
| } | ||
| $tags = $this->systemTagObjectMapper->getTagIdsForObjects($targetNode->getId(), 'files'); |
Check failure
Code scanning / Psalm
InvalidArgument
| ->setDescription('Add a system-tag to a file or folder') | ||
| ->addArgument('target', InputArgument::REQUIRED, "file id or path") | ||
| ->addArgument('tags', InputArgument::REQUIRED, "Name of the tag(s) to add, comma separated") | ||
| ->addArgument('access', InputArgument::REQUIRED, 'access level of the tag (public, restricted or invisible)'); |
There was a problem hiding this comment.
It feels weird that access is required for assigning an existing tag
There was a problem hiding this comment.
I think it is required because
- the same tagName can exist with different access level
- I want to work around the missing exif support (Show and edit EXIF Tags photos#226) by automatically creating the tags if it does not exist
There was a problem hiding this comment.
I want to work around the missing exif support (nextcloud/photos#226) by automatically creating the tags if it does not exist
We do support EXIF data, they are currently stored with the FilesMetadata API: https://github.com/nextcloud/photos/blob/f70a0486642e166c69bdd45a480288e05ba5faa9/lib/Listener/ExifMetadataProvider.php
There was a problem hiding this comment.
please replace EXIF with metadata/xmp...
I'm using the exiftool to extract metadata. The tool is able to extract the XMP information and TagsList is part of XMP, not EXIF
ExifMetadataProvider does indeed store the EXIF part of the metadata, but this only includes things like GPS, Time, size,...
Uh oh!
There was an error while loading. Please reload this page.
34cde37 to
819385cCompareHello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
819385c to
c57f2faCompare| class DeleteAll extends Command { | ||
| public function __construct( | ||
| private FileUtils $fileUtils, |
There was a problem hiding this comment.
I'm not sure if FileUtils is recommended to be used in apps even if they're in server
marcelklehr
commented
Jan 29, 2025
@schaarsc Psalm is still failing with an error talking about a wrong argument type |
Resolvenextcloud#32735 Signed-off-by: schaarsc <schaarsc@users.noreply.github.com>
c57f2fa to
778ae6aComparemarcelklehr
commented
Jan 30, 2025
How do we merge since CI fails because it doesn't want to run on forks? |
come-nc
commented
Feb 4, 2025
Ask a team lead to force-merge |
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
Summary
adds the following commands to the files app:
files:tag-add <target> <tags> <access>files:tag-delete <target> <tags> <access>files:tag-delete-all <target>TODO
Checklist