Uh oh!
There was an error while loading. Please reload this page.
fix: Ensure app discover section is returned as list - #48311
Merged
Conversation
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
requested review from
a team, ArtificialOwl, come-nc, szaimen and yemkareems
and removed request for
a teamSeptember 24, 2024 10:36
susnux
commented
Sep 24, 2024
ContributorAuthor
/backport to stable30 |
susnux
commented
Sep 24, 2024
ContributorAuthor
/backport to stable29 |
susnuxforce-pushed
the
fix/app-discover
branch
from
September 24, 2024 10:36
6f48f2f to
9bc0aa0Compareszaimen
approved these changes
Sep 24, 2024
szaimen
left a comment
Contributor
There was a problem hiding this comment.
Explanation and fix makes sense but didnt test
nfebe
approved these changes
Sep 24, 2024
This was referenced Sep 24, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The frontend expects a list (array) but if the filter removes entries the php array is not sequential meaning it will be serialized as an object to JSON.
Checklist