Skip to content

fix: Show storage full warning when storage is actually full - #48354

Merged
artonge merged 1 commit into
masterfrom
artonge/fix/storage_full_warning
Sep 26, 2024
Merged

fix: Show storage full warning when storage is actually full#48354
artonge merged 1 commit into
masterfrom
artonge/fix/storage_full_warning

Conversation

@artonge

@artongeartonge commented Sep 25, 2024•
edited
Loading

Copy link
Copy Markdown
Collaborator

< 0 values for "free" do not mean that the storage is full:

server/lib/public/Files/FileInfo.php

Lines 27 to 41 in 6befdd6

/**
* @const \OCP\Files\FileInfo::SPACE_NOT_COMPUTED Return value for a not computed space value
* @since 8.0.0
*/
publicconstSPACE_NOT_COMPUTED = -1;
/**
* @const \OCP\Files\FileInfo::SPACE_UNKNOWN Return value for unknown space value
* @since 8.0.0
*/
publicconstSPACE_UNKNOWN = -2;
/**
* @const \OCP\Files\FileInfo::SPACE_UNLIMITED Return value for unlimited space
* @since 8.0.0
*/
publicconstSPACE_UNLIMITED = -3;

Signed-off-by: Louis Chemineau louis@chmn.me

  • Resolves: #

Summary

TODO

  • ...

Checklist

@artongeartonge self-assigned this Sep 25, 2024
@artonge
artonge requested a review from susnuxSeptember 25, 2024 11:54
@artongeartonge added this to the Nextcloud 31 milestone Sep 25, 2024
@artonge

artonge commented Sep 25, 2024

Copy link
Copy Markdown
CollaboratorAuthor

/backport to stable28

@artonge

artonge commented Sep 25, 2024

Copy link
Copy Markdown
CollaboratorAuthor

/backport to stable29

@artonge

artonge commented Sep 25, 2024

Copy link
Copy Markdown
CollaboratorAuthor

/backport to stable30

@artonge
artongeforce-pushed the artonge/fix/storage_full_warning branch from cb2bc91 to 1046f8dCompareSeptember 25, 2024 15:48
@artonge

artonge commented Sep 25, 2024

Copy link
Copy Markdown
CollaboratorAuthor

/compile amend /

@nextcloud-command
nextcloud-commandforce-pushed the artonge/fix/storage_full_warning branch from 1046f8d to ee03123CompareSeptember 25, 2024 15:56
@artonge

This comment was marked as duplicate.

Sign in to view
@artonge

This comment was marked as duplicate.

Sign in to view
@artonge

This comment was marked as duplicate.

Sign in to view
@artonge
fix: Show storage full warning when storage is actually full
d576efb
< 0 values for "free" do not mean that the storage is full: https://github.com/nextcloud/server/blob/6befdd6dd7cd20fe7f7036e4665bcfbb783d6803/lib/public/Files/FileInfo.php#L31-L42
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@artonge
artongeforce-pushed the artonge/fix/storage_full_warning branch from ee03123 to d576efbCompareSeptember 25, 2024 17:42
@artonge
artonge merged commit 098f3c1 into masterSep 26, 2024
@artonge
artonge deleted the artonge/fix/storage_full_warning branch September 26, 2024 08:38
This was referenced Sep 26, 2024
Merged
Merged
Merged
@skjnldsvskjnldsv mentioned this pull request Jan 7, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnuxsusnuxsusnux approved these changes
@provokateurinprovokateurinprovokateurin approved these changes
@skjnldsvskjnldsvAwaiting requested review from skjnldsvskjnldsv is a code owner

Assignees

@artongeartonge

Labels

3. to reviewWaiting for reviewsbugfeature: filesjavascript

Projects

None yet

Milestone

Nextcloud 31

Development

Successfully merging this pull request may close these issues.

3 participants

@artonge@susnux@provokateurin