Uh oh!
There was an error while loading. Please reload this page.
fix(files_sharing): Parse OCM share permissions from OCM and not OCS prop - #48366
Merged
Conversation
…prop Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin
commented
Sep 26, 2024
MemberAuthor
/backport to stable30 |
provokateurin
commented
Sep 26, 2024
MemberAuthor
/backport to stable29 |
provokateurin
commented
Sep 26, 2024
MemberAuthor
/backport to stable28 |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
come-nc
reviewed
Sep 26, 2024
Uh oh!
There was an error while loading. Please reload this page.
come-nc
reviewed
Sep 26, 2024
come-nc
left a comment
Contributor
There was a problem hiding this comment.
Ok for the logic, but error handling is missing, $reponse could be false, or could be missing the keys.
Signed-off-by: provokateurin <kate@provokateurin.de>
…ing share permission props Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurinforce-pushed
the
fix/files_sharing/ocm-permissions
branch
from
September 26, 2024 12:35
9266e84 to
13d1cb7Comparecome-nc
approved these changes
Sep 26, 2024
kesselb
approved these changes
Sep 26, 2024
This was referenced Sep 26, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checks for OCM permissions prop, but parses them from the OCS permissions prop.
Checklist