Skip to content

[stable28] fix(Auth): ignore missing token when trying to set password-unconfirmable - #48445

Merged
blizzz merged 1 commit into
stable28from
fix/noid/ignore-unavailable-token
Oct 1, 2024
Merged

[stable28] fix(Auth): ignore missing token when trying to set password-unconfirmable#48445
blizzz merged 1 commit into
stable28from
fix/noid/ignore-unavailable-token

Conversation

@blizzz

@blizzzblizzz commented Sep 30, 2024

Copy link
Copy Markdown
Member

Summary

When the token is unavailable an Excpetion may kill the running request.

Checklist

…able
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzzblizzz added the 3. to review Waiting for reviews label Sep 30, 2024
@blizzzblizzz added this to the Nextcloud 28.0.11 milestone Sep 30, 2024
@blizzzblizzz changed the title fix(Auth): ignore missing token when trying to set password-unconfirmable[stable28] fix(Auth): ignore missing token when trying to set password-unconfirmableSep 30, 2024

@julien-ncjulien-nc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good though I have no clue how these exceptions are dealt with somewhere else.

@blizzz
blizzz marked this pull request as ready for review October 1, 2024 10:16
@blizzz

blizzz commented Oct 1, 2024

Copy link
Copy Markdown
MemberAuthor

Looks good though I have no clue how these exceptions are dealt with somewhere else.

OC\User\Session is dealing with them.

@blizzz

Copy link
Copy Markdown
MemberAuthor

/backport to stable27

@blizzz
blizzz merged commit e3cce26 into stable28Oct 1, 2024
@blizzz
blizzz deleted the fix/noid/ignore-unavailable-token branch October 1, 2024 13:57
@AltahrimAltahrim mentioned this pull request Oct 1, 2024
2 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@blizzz@kesselb@julien-nc