Skip to content

fix(dav): don't crash subscription on invalid calendar object - #48519

Merged
SebastianKrupinski merged 1 commit into
masterfrom
bug/48518/ignore-invalid-dates
Oct 2, 2024
Merged

fix(dav): don't crash subscription on invalid calendar object#48519
SebastianKrupinski merged 1 commit into
masterfrom
bug/48518/ignore-invalid-dates

Conversation

@kesselb

Copy link
Copy Markdown
Contributor

Summary

Local version of #48349 to have a full CI run.

TODO

  • CI
  • Review

Checklist

Signed-off-by: escoand <escoand@users.noreply.github.com>
@kesselbkesselb added bug 3. to review Waiting for reviews labels Oct 2, 2024
@kesselbkesselb added this to the Nextcloud 31 milestone Oct 2, 2024
@kesselbkesselb self-assigned this Oct 2, 2024
@kesselbkesselb added the feature: caldav Related to CalDAV internals label Oct 2, 2024
@SebastianKrupinski
SebastianKrupinski merged commit 2d004c3 into masterOct 2, 2024
@SebastianKrupinski
SebastianKrupinski deleted the bug/48518/ignore-invalid-dates branch October 2, 2024 13:04
@kesselb

Copy link
Copy Markdown
ContributorAuthor

/backport to stable30

@SebastianKrupinski

Copy link
Copy Markdown
Contributor

/backport to stable29

@kesselb

Copy link
Copy Markdown
ContributorAuthor

The user wrote that the problem does not happen on 29.0.7 and the line that throws the exception does not exist in 29, so I closed the 29 backport.

@skjnldsvskjnldsv mentioned this pull request Jan 7, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbugfeature: caldavRelated to CalDAV internals

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Failure on subscribing to a public Google calendar

4 participants

@kesselb@SebastianKrupinski@miaulalala@escoand