Skip to content

fix: do not reduce count for subadmins if they are members of group - #48532

Merged
blizzz merged 1 commit into
masterfrom
fix/48437/dont-exclude-user
Oct 4, 2024
Merged

fix: do not reduce count for subadmins if they are members of group#48532
blizzz merged 1 commit into
masterfrom
fix/48437/dont-exclude-user

Conversation

@Antreesy

@AntreesyAntreesy commented Oct 2, 2024

Copy link
Copy Markdown
Contributor

Summary

Counter on sidebar doesn't reflect the actual number of group members, if subadmin is a member too.
For each group, counter is reduced by 1, and for 'All accounts', counter is reduced by amount of groups subadmin is in.

There is a comment:

we prevent subadmins from looking up themselves so we lower the count of the groups he belongs to

but I don't see a point of it, since we fetch and show yourself in the list anyway, so just removing inconsistency

BeforeAfter
imageimage
Subadmin: 'alice', member of 'test group' and 'test group 2'

TODO

  • ...

Checklist

@AntreesyAntreesy added this to the Nextcloud 31 milestone Oct 2, 2024
@AntreesyAntreesy self-assigned this Oct 2, 2024
@Antreesy
Antreesyforce-pushed the fix/48437/dont-exclude-user branch from f460c33 to 583f015CompareOctober 2, 2024 13:55
Comment threadapps/settings/lib/Controller/UsersController.php Outdated
@provokateurin

Copy link
Copy Markdown
Member

/backport to stable30

@provokateurin

Copy link
Copy Markdown
Member

/backport to stable29

@provokateurin

Copy link
Copy Markdown
Member

/backport to stable28

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
Antreesyforce-pushed the fix/48437/dont-exclude-user branch from 583f015 to 0d6acbfCompareOctober 2, 2024 16:33
@backportbot

This comment was marked as outdated.

@Antreesy

Copy link
Copy Markdown
ContributorAuthor

/backport to stable30

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Antreesy@provokateurin@blizzz