Skip to content

build: Bump symfony/* to 6.4 - #48539

Merged
nickvergessen merged 10 commits into
masterfrom
dependabot/composer/symfony-6.4
Oct 7, 2024
Merged

build: Bump symfony/* to 6.4#48539
nickvergessen merged 10 commits into
masterfrom
dependabot/composer/symfony-6.4

Conversation

@nickvergessen

@nickvergessennickvergessen commented Oct 2, 2024

Copy link
Copy Markdown
Member

Summary

Prod PackagesOperationBaseTarget
psr/logUpgraded2.0.03.0.2
stecman/symfony-console-completionUpgraded0.11.0v0.13.0
symfony/consoleUpgradedv5.4.35v6.4.12
symfony/event-dispatcherUpgradedv5.4.26v6.4.8
symfony/event-dispatcher-contractsUpgradedv3.0.2v3.5.0
symfony/http-foundationUpgradedv5.4.25v6.4.12
symfony/mailerUpgradedv5.4.22v6.4.12
symfony/mimeUpgradedv5.4.19v6.4.12
symfony/polyfill-intl-idnUpgradedv1.29.0v1.31.0
symfony/polyfill-php83New-v1.31.0
symfony/processUpgradedv5.4.34v6.4.12
symfony/routingUpgradedv5.4.25v6.4.12
symfony/service-contractsUpgradedv3.0.2v3.5.0
symfony/polyfill-php72Removedv1.29.0-
symfony/polyfill-php73Removedv1.28.0-

Checklist

@nickvergessennickvergessen added 3. to review Waiting for reviews pending documentation This pull request needs an associated documentation update dependencies labels Oct 2, 2024
@nickvergessennickvergessen added this to the Nextcloud 31 milestone Oct 2, 2024
@nickvergessennickvergessen self-assigned this Oct 2, 2024
@nickvergessen
nickvergessenforce-pushed the dependabot/composer/symfony-6.4 branch 2 times, most recently from 9b38338 to 4e53eccCompareOctober 4, 2024 14:26
Comment threadbuild/psalm-baseline.xml Outdated
Comment threadcore/Command/Db/ConvertFilecacheBigInt.php
Comment threadapps/files_external/lib/Command/Option.php Outdated
Comment threadapps/files_external/lib/Command/Option.php
@nickvergessen
nickvergessenforce-pushed the dependabot/composer/symfony-6.4 branch from 4e53ecc to 998d972CompareOctober 7, 2024 10:03
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
…dparty bump)
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
…meterOption calls
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
nickvergessenforce-pushed the dependabot/composer/symfony-6.4 branch from 998d972 to 315e465CompareOctober 7, 2024 10:12
@come-nc

Copy link
Copy Markdown
Contributor

Can we document based on the arguments? I don't think so

@nickvergessen To be precise, I think we can with https://psalm.dev/docs/annotating_code/type_syntax/conditional_types/ , but it’s a bit complicated.

Maybe we should simply add in Base:

functiongetQuestionHelper(): QuestionHelper {
/** @var QuestionHelper */return$this->getHelper('question');
}

Seeing how often this is used.

@nickvergessen

Copy link
Copy Markdown
MemberAuthor

Maybe we should simply add in Base:

I'm up for that, if we add a public interface. I don't feel like typing 3rdparty with implied assumptions

@nickvergessen
nickvergessen merged commit c3dfb9a into masterOct 7, 2024
@nickvergessen
nickvergessen deleted the dependabot/composer/symfony-6.4 branch October 7, 2024 11:08
kesselb added a commit to kesselb/nextcloud-ocp that referenced this pull request Oct 8, 2024
Follow up for nextcloud/3rdparty#1956 and nextcloud/server#48539
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@nickvergessen

Copy link
Copy Markdown
MemberAuthor

/backport e6cd105 to stable29

@nickvergessen

Copy link
Copy Markdown
MemberAuthor

/backport e6cd105 to stable28

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsdependenciespending documentationThis pull request needs an associated documentation update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@nickvergessen@come-nc@susnux@kesselb