Skip to content

fix(theming): Fix layout of themes - #48543

Merged
Pytal merged 2 commits into
masterfrom
fix/themes-layout
Oct 3, 2024
Merged

fix(theming): Fix layout of themes#48543
Pytal merged 2 commits into
masterfrom
fix/themes-layout

Conversation

@Pytal

@PytalPytal commented Oct 2, 2024

Copy link
Copy Markdown
Member

Summary

Fix#48407

BeforeAfter
imageimage

Checklist

Signed-off-by: Christopher Ng <chrng8@gmail.com>
@PytalPytal added bug design Design, UI, UX, etc. 3. to review Waiting for reviews feature: theming labels Oct 2, 2024
@PytalPytal added this to the Nextcloud 31 milestone Oct 2, 2024
@Pytal
Pytal requested review from a team and nfebeOctober 2, 2024 23:23
@PytalPytal self-assigned this Oct 2, 2024
@Pytal
Pytal requested review from artonge and susnux and removed request for a teamOctober 2, 2024 23:23
@Pytal

Pytal commented Oct 2, 2024

Copy link
Copy Markdown
MemberAuthor

/compile

@Pytal

Pytal commented Oct 2, 2024

Copy link
Copy Markdown
MemberAuthor

/backport to stable30

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@ShGKme

Copy link
Copy Markdown
Contributor

If I'm not mistaken, @marcoambrosini had some plans here, was discussed when NcSettingsSection become force limited

@susnuxsusnux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better :)
Yet I think limiting the width is an mistake here, like with the profile settings it should take more horizontal space as 1920px is basically the norm today.

@Pytal
Pytal merged commit 9095b49 into masterOct 3, 2024
@Pytal
Pytal deleted the fix/themes-layout branch October 3, 2024 12:28
@marcoambrosini

Copy link
Copy Markdown
Member

Nice improvement!

@marcoambrosini

Copy link
Copy Markdown
Member

Yet I think limiting the width is an mistake here, like with the profile settings it should take more horizontal space as 1920px is basically the norm today.

Since there can be long paragraphs in the settings, I'd like to limit the width to improve readability

@Pytal

Pytal commented Oct 3, 2024

Copy link
Copy Markdown
MemberAuthor

Yet I think limiting the width is an mistake here, like with the profile settings it should take more horizontal space as 1920px is basically the norm today.

Since there can be long paragraphs in the settings, I'd like to limit the width to improve readability

The width is force-limited to 900px already on 30+ but do you think we should limit it more @marcoambrosini?

@marcoambrosini

Copy link
Copy Markdown
Member

I think that's ok @Pytal !

@skjnldsvskjnldsv mentioned this pull request Jan 7, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbugdesignDesign, UI, UX, etc.feature: theming

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Theme previews / selector looks to crowded

6 participants

@Pytal@ShGKme@marcoambrosini@susnux@artonge@nextcloud-command